generic-library/rapidjson
1
0
Fork 0
mirror of https://github.com/Tencent/rapidjson.git synced 2025-10-27 19:10:24 +01:00
Code Issues Projects Releases Wiki Activity

do potentially precision-losing conversions explicitly

Browse Source
This commit is contained in:
Konstantin Trushin
2016-03-13 14:07:39 +03:00
parent d454d21409
commit 305882489c
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/rapidjson/pointer.h
View File

@@ -987,11 +987,11 @@ private:
src_++; src_++;
Ch c = 0; Ch c = 0;
for (int j = 0; j < 2; j++) { for (int j = 0; j < 2; j++) {
c <<= 4; c = static_cast<Ch>(c << 4);
Ch h = *src_; Ch h = *src_;
if (h >= '0' && h <= '9') c += h - '0'; if (h >= '0' && h <= '9') c = static_cast<Ch>(c + h - '0');
else if (h >= 'A' && h <= 'F') c += h - 'A' + 10; else if (h >= 'A' && h <= 'F') c = static_cast<Ch>(c + h - 'A' + 10);
else if (h >= 'a' && h <= 'f') c += h - 'a' + 10; else if (h >= 'a' && h <= 'f') c = static_cast<Ch>(c + h - 'a' + 10);
else { else {
valid_ = false; valid_ = false;
return 0; return 0;

4
test/unittest/itoatest.cpp
View File

@@ -93,7 +93,7 @@ static void u32toa_naive(uint32_t value, char* buffer) {
char temp[10]; char temp[10];
char *p = temp; char *p = temp;
do { do {
*p++ = char(value % 10) + '0'; *p++ = static_cast<char>(char(value % 10) + '0');
value /= 10; value /= 10;
} while (value > 0); } while (value > 0);
@@ -117,7 +117,7 @@ static void u64toa_naive(uint64_t value, char* buffer) {
char temp[20]; char temp[20];
char *p = temp; char *p = temp;
do { do {
*p++ = char(value % 10) + '0'; *p++ = static_cast<char>(char(value % 10) + '0');
value /= 10; value /= 10;
} while (value > 0); } while (value > 0);

2
test/unittest/strtodtest.cpp
View File

@@ -42,7 +42,7 @@ TEST(Strtod, CheckApproximationCase) {
u.u = 0x465a72e467d88 | ((static_cast<uint64_t>(-149 + kExponentBias)) << kSignificandSize); u.u = 0x465a72e467d88 | ((static_cast<uint64_t>(-149 + kExponentBias)) << kSignificandSize);
const double b = u.d; const double b = u.d;
const uint64_t bInt = (u.u & kSignificandMask) | kHiddenBit; const uint64_t bInt = (u.u & kSignificandMask) | kHiddenBit;
const int bExp = ((u.u & kExponentMask) >> kSignificandSize) - kExponentBias - kSignificandSize; const int bExp = static_cast<int>(((u.u & kExponentMask) >> kSignificandSize) - kExponentBias - kSignificandSize);
EXPECT_DOUBLE_EQ(1.7864e-45, b); EXPECT_DOUBLE_EQ(1.7864e-45, b);
EXPECT_EQ(RAPIDJSON_UINT64_C2(0x001465a7, 0x2e467d88), bInt); EXPECT_EQ(RAPIDJSON_UINT64_C2(0x001465a7, 0x2e467d88), bInt);
EXPECT_EQ(-201, bExp); EXPECT_EQ(-201, bExp);