* fix(Data::AbstracSessionImpl): protect autocommit feature handlers #4261
* chore(CI): re-enable mysql
* MySQL SessionImpl: make sure autocommit mode is on when session is openend or reset.
* PostgreSQL SessionImpl: reuse autocommit flag of AbstractSessionImpl.
* Github workflow: re-activated linux-gcc-make-postgres
* Fixed indentation in ci.yml
* Fix for DataTest SQLExecutor: use connector
* Data::Session: when parser is not used and autocommit mode is off, assume any SQL statement begins a transaction.
* PostgreSQL: don't use SQL parser (it currently cannot handle placeholders).
* PostgreSQL: added test sessionTransactionNoAutoCommit
* PostgreSQL test suite: removed reference to generic SQLExecutor
* PostgreSQL: fixes for sessionTransactionNoAutoCommit.
* MySQL: added test sessionPoolAndUnicode (from #2801)
* Fixed #define in sql-parser
* Data generic testsuite: support numbered placeholders
* PostgreSQL test suite: added missing include directory to Makefile.
* Attempt to fix PostgreSQL Makefiles
* PostgreSQL testsuite: added include path to Makefile
* PostgreSQL testsuite: added PocoDataTest library to Makefile
* DataTest SQLExecutor::formatSQL: don't use string_view
* PostgreSQL test suite: delegated most tests to Poco::Data::Test
* Makefile: added dependencies on Data-Tests
* Weaken assumptions about async in generic transaction tests
* Makefile: added dependency for Prometheus samples
* Fix deadlock in DataTest SQLExecutor
* PostgreSQL tests SQLExecutor: cleanup
* feat(Data::AbstractSessionImpl): add autoCommit property and tests #4261
* Brought MySQL backend in line with _autoCommit flag of AbstractSessionImpl.
---------
Co-authored-by: Friedrich Wilckens <frwilckens@gmail.com>
Co-authored-by: Friedrich Wilckens <friedrich.wilckens@ingramcontent.com>
* directoryiterator: Fix missing inline
Add missing inline to inline function.
This was found with clang-tidy check: misc-definitions-in-headers
* Convert deprecated throw() to noexcept
throw() has been deprecated in standar in C++17. It has been removed in
C++20. Code still compiles but let's just define these at those should
be.
These where found with clang-tidy check: modernize-use-noexcept
* Fix unnecessary copy initializations
Clang-tidy did find these with check:
performance-unnecessary-copy-initialization
* Fix some strings not references
Looks like these are just missing reference marks.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
* Remove _WIN32_WCE macro
Poco now use C++17 and Windows CE does not support it and VS2017 does
also not support it so we can just remove Windows CE code. First remove
all macro usages from our own files.
* Remove WinCE support from build files
Poco now use C++17 and Windows CE does not support it and VS2017 does
also not support it so we can just remove Windows CE code. Remove all
references from build systems / scripts.
* Remove Windows CE related source and header files
Poco now use C++17 and Windows CE does not support it and VS2017 does
also not support it so we can just remove Windows CE code. First remove
all macro usages from our own files.
* Remove wcelibcex folder
Poco now use C++17 and Windows CE does not support it and VS2017 does
also not support it so we can just remove Windows CE code. First remove
all macro usages from our own files.
* Remove rest Windows CE mentions
There where some Windows CE mentions left. Remove those.
* Update Windows CE documentation
We should keep documentation some time so people can find reason for
remove.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
Poco now use C++17. We can take some old code away because of that. We
also raise requiments for C++17 so everything works as excpected with
it.
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
* GH #569: Cherry pick and correct code from devel-experimental.
* GH #569: Add missing timezone codes.
* enh(Foundation): DateTimeParser: stricter checks of timezones, more tests for invalid inputs. (#569)
* enh(Foundation): Small fixes of issues detected by CodeQL
---------
Co-authored-by: Alex Fabijanic <alex@pocoproject.org>
* add sendfile method for streamsocket
* add mswsock.lib to the project files and templates
* remove /DPOCO_NO_AUTOMATIC_LIBS for cmake windows build
* merge from upstream
* merge from upstream
* fix code stile
add NotImplemented exception for unsupported platforms
exculude <sys/sendfile.h> for POCO_EMSCRIPTEN, because https://
github.com/emscripten-core/emscripten/pull/16234
* add iostream include for std::cout
* fix compilation for emscripten (wrap sendfile)
* Merge remote-tracking branch 'jackywoo/add_self_to_path' into 2282-path-self
* fix(Foundation): minor code cleanup. #2282
* enh(Foundation): Windows unit test for Path::self and exception for non-implemented platform.
* fix(Foundation): Path::self() throws SystemException when the path can't be acquired. #2282
Co-developed-by: Jackie Woo <wuchienchao@qq.com>
Co-developed-by: Matej Kenda <matejken@gmail.com>
* Made it possible to use lowercase hex numbers, also when encoding JSON (#3102)
Co-authored-by: Thomas Weyn <Thomas.Weyn@cebir.be>
* fix(JSONString): Remove deprecated toJSON functions #4305
* fix(NumericString): conversions inconsistencies #4304
---------
Co-authored-by: Archipel <thomas@weynwebworks.com>
Co-authored-by: Thomas Weyn <Thomas.Weyn@cebir.be>
Common knowledge in reference counting is "on assignment increment first
then decrement", because "just to be deleted" object could hold last
reference to "just to be assigned" one.
Fixes#3979
SplitterChannel::addChannel() should only add a channel once to the internal vector. This prevents issues where the channel is accidentally added twice but only removed once because removeChannel stops at the first result. (#4270)
* add visitor pattern implementation for Poco::Dynamic::Var
* add changes to Makefile and vcxproj for VarVisitor
* resolve review comments Poco::Dynamic::Var
---------
Co-authored-by: Alexander B <bas524@ya.ru>
* fix(SQLParser): use Data_API if available
* fix(ProGen): wrong AdditionalOptions separator #4259
* fix(SQLParser): add default export define when embedded
* feat(ci): run pull request runs only on pull request open #4205
* feat(ci): add retry action for tsan #4205
* feat(ci): use local action for retrying tsan #4205
* fix(ci): use correct version of retry action #4205
* fix: make POSIX event thread safe
* feat(ci): add info on retry action to ci.yml header #4205
* feat(ci): add linux mysql test #4205
* feat(ci): remove unused mysql containers from tests#4205
* feat(ci): add linux postgre test #4205
* feat(ci): add linux redis test #4205
* feat(ci): add linux mongodb tests #4205
* feat(ci): add mysql odbc test #4205
* chore(ci): rename tests #4205
* chore(ci): pin postgres and mysql versions #4205
* feat(ci): add odbc postgres tests #4205
* chore(ci): mysql odbc comment #4205
* chore(ci): disable windows 2019 job #4205
* feat(ci): add linux oracle tests #4205
* chore(ci): disable oracle tests #4205
* feat(ci): add sql server tests #4205
* chore(ci): disable postgres tests #4205
* chore(ci): add logging for task test #4205
* feat(ci): add local retry action #4205
* feat(ci): ignore process kill failure in action #4205
* feat(ci): send SIGKILL instead of SIGTERM in action #4205
* chore(ci): add updated action #4205
* chore(ci): reduce tsan timeout #4205
* feat(ci): kill process without children #4205
* feat(ci): send SIGTERM to child in action #4205
* feat(ci): prolong tsan timeout #4205
* chore(ci): add missing newlines #4205
* fix(ci): revert sql server test FreeTDS version #4205
* feat(ci): add retry to all jobs #4205
* feat(ci): setup python for codeQL #4205
* chore(ci): disable throwing on codeql error #4205
* fix(Net): Add Unix socket support on windows #4208
* feat(Net): add abstract local socket support #4208
* fix(PollSet): use localhost socket in PollSet on windows when available #4208
* fix(PollSetTest): comment checking unconnected sockets status (Linux epoll signals them as readable/writable)
* Fix pthread_setname not declared #4063
* Fix include prctl.h for specific OS #4063
* Fix getThreadName for specific OS #4063
---------
Co-authored-by: root <root@debian-gnu-linux-11.localdomain>
Co-authored-by: Pavle <pavle@debian-gnu-linux-11.localdomain>
/data/mwrep/res/osp/Poco/Foundation/23-0-0-0/include/Poco/Dynamic/VarHolder.h: In instantiation of 'void Poco::Dynamic::VarHolder::checkUpperLimit(const F&) const [with F = signed char; T = unsigned int; typename std::enable_if<std::is_integral<_Tp>::value, bool>::type <anonymous> = true]':
/data/mwrep/res/osp/Poco/Foundation/23-0-0-0/include/Poco/Dynamic/VarHolder.h:361:23: required from 'void Poco::Dynamic::VarHolder::convertSignedToUnsigned(const F&, T&) const [with F = signed char; T = unsigned int]'
/data/mwrep/res/osp/Poco/Foundation/23-0-0-0/include/Poco/Dynamic/VarHolder.h:799:26: required from here
/data/mwrep/res/osp/Poco/Foundation/23-0-0-0/include/Poco/Dynamic/VarHolder.h:405:26: error: comparison of integer expressions of different signedness: 'const signed char' and 'unsigned int' [-Werror=sign-compare]
405 | if (from > std::numeric_limits<T>::max())
| ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Instead, replace it with std::max_align_t in the Any implementation, as
really we would like to be able to store any object with any alignment
in the small object optimization case. Typically the size and alignment
of std::max_align_t is 8 or 16 on most platforms. Added a static assert
to ensure that this change doesn't result in wasting more unused memory
in case the size of the storage buffer is smaller than this maximum
alignment (which is right now 64, so shall be ok on all platforms).
* Complimentary to #3918
I think that we can use Poco::Mutex and Poco::FastMutex as wrappers for std::recursive_mutex and std::mutex instead of replacing
For using std::*mutexes switch on cmake-option POCO_ENABLE_STD_MUTEX
* add define POCO_ENABLE_STD_MUTEX to the Config.h
remove empty if-else from CMakeLists.txt
Consider following situation. A class owns a timer. In destructor of that class we call .cancel() asynchronous on timer before it's destruction.
Now timer is executing cancel in it's own internal thread, while it's doing that destructor of timer is called from owner's destructor. Timer destructor enqueues stop notification. If that enqueue is happening just after while loop from cancel notification, stop notification is gonna be dropped and timer will never stop.
Fix: Add new method in TimedNotificationQueue which will return a notification regardless of the time it needs to be executed.
Get number of pending tasks in the queue. Flush out that many notifications from queue while taking special consideration of pending Stop and Cancel notifications.
Add test for new method in TimedNotificationQueue and fix cancel all tests to actually check if notification got executed.
fixes#3986
* Binary writer/reader: add writeCString and readCString.
* MongoDB::Database: add queryBuildInfo and queryServerHello; add WireVersion enum.
* MongoDB: Introduce OpMsgMessage (request and reply) and related changes in Connection, Database, MessageHeader.
* MongoDB: First unit test changes for OpMsgMessage.
* MongoDB::Document: new functions addNewArray and remove.
* MongoDB: OP_MSG unacknowledged write and many improvements
* MongoDB: new cursor using OP_MSG
* MongoDB: bunch of new tests for OP_MSG wire protocol.
* BinaryWriter::WriteCString: use write instead of operator <<.
* MongoDB::OpMsgCursor: Slightly modified prototype code for using moreToCome flag.
* MongoDB: Add OpMsg* files to Makefiles.
* MongoDB: Add OpMsg* files to VS project files.
* Compile fixes.
* MongoDB::Database: Add factory function for database commands createOpMsgMessage() and cursors createOpMsgCursor()
* Improve implementation of logging macros. #2331
The GNU compiler emits a warning if nested "if" statements are followed by
an "else" statement and braces are not used to explicitly disambiguate the
"else" binding. This leads to problems with code like:
if (gate)
ASSERT_*(condition) << "Some message";
The "switch (0) case 0:" idiom is used to suppress this.
* I was wrong.
do-while better then switch-case approach for "ambiguous else blocker"
https://godbolt.org/z/W5nnYrzx6
* try to fix tabs
* again fix tabs
* again fix tabs
* again fix tabs
* try fix compilation for solaris
* this commit for issue #3843 and #3643
changes in Types.h allow ignore problem with declaration of std::int8_t. int8_t can be defined as char or signed char. IMHO we need strong types for Poco::Int's
Envelop.cpp contains initializer for EVP_CIPHER_CTX_init, because this function prototype depends on openssl version.
Application.cpp contains includes especial for SOLARIS, for ioctl support
ClassLoaderTest.cpp and SharedLibraryTest.cpp contains changes because loadlibrary(dlopen) doesn't load library from current directory by default
LocalDateTimeTest.cpp contains changes because SOLARIS use std::tm without tm_gmtoff
* fix : define of SOLARIOS OS in LocalDateTimeTest
* remove unnecessary wrapper
* fix output dir for windows build with multi-config build
* try to fix bug with unixodbc version in linux-builds
[read here](https://github.com/microsoft/linux-package-repositories/issues/36)
* try to fix bug with unixodbc version in linux-builds
[read here](https://github.com/microsoft/linux-package-repositories/issues/36)
* fix : warning in main cmake for if-condition for multi-config build
fix : error for linux-gcc-make-cxx20, use --allow-downgrades for unixodbc
* fix : warning for cmake windows builds
revert changes for linux-gcc-make-cxx20
* revert ci.yml, remove unixodbc version
* try re-run build
---------
Co-authored-by: Aleksandar Fabijanic <aleks-f@users.noreply.github.com>
There was 1 failure:
1: N7CppUnit10TestCallerI7VarTestEE.testDynamicStructEmptyString
"expected: "{ "Empty": "", "Space": }" but was: "{ "Empty": "", "Space": " " }""
in "src/VarTest.cpp", line 2294
It's happen because in test we call aStruct.toString(false).
It's mean that we don't expect wrapping, but expected result was written with wrapping
