generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-07-03 01:05:21 +02:00
Code Issues Projects Releases Wiki Activity

Allow ADL for swapping Optional values (#4569)

Browse Source 
Some types support being swapped but may not have declared their
std::swap overloads when Poco/Optional.h is first included. This is the
case for instance with

    #include <Poco/Optional.h>
    #include <array>

    using Problematic = Poco::Optional<std::array<int, 42> >;

With an unqualified call to swap, preceded by using std::swap, we allow
argument-dependent lookup to find suitable implementations of swap.
This commit is contained in:
Jouke Witteveen 2024-06-17 16:52:49 +02:00 committed by GitHub
parent c6249d9b3f
commit e00b4de672
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Foundation/include/Poco/Optional.h
View File

@ -143,8 +143,9 @@ public:
void swap(Optional& other) noexcept void swap(Optional& other) noexcept
{ {
std::swap(_value, other._value); using std::swap;
std::swap(_isSpecified, other._isSpecified); swap(_value, other._value);
swap(_isSpecified, other._isSpecified);
} }
const C& value() const const C& value() const