Merge pull request #45 from RangelReale/jsonunicode

* Fix JSON unicode handling
This commit is contained in:
Aleksandar Fabijanic 2012-12-29 04:10:48 -08:00
commit dcf92dcfe3
3 changed files with 47 additions and 10 deletions

View File

@ -38,6 +38,7 @@
#include "Poco/JSON/JSONException.h" #include "Poco/JSON/JSONException.h"
#include "Poco/Ascii.h" #include "Poco/Ascii.h"
#include "Poco/Token.h" #include "Poco/Token.h"
#include "Poco/UnicodeConverter.h"
#undef min #undef min
#undef max #undef max
#include <limits> #include <limits>
@ -140,28 +141,28 @@ public:
switch(c) switch(c)
{ {
case '"' : case '"' :
c = '"'; _value += '"';
break; break;
case '\\' : case '\\' :
c = '\\'; _value += '\\';
break; break;
case '/' : case '/' :
c = '/'; _value += '/';
break; break;
case 'b' : case 'b' :
c = '\b'; _value += '\b';
break; break;
case 'f' : case 'f' :
c = '\f'; _value += '\f';
break; break;
case 'n' : case 'n' :
c = '\n'; _value += '\n';
break; break;
case 'r' : case 'r' :
c = '\r'; _value += '\r';
break; break;
case 't' : case 't' :
c = '\t'; _value += '\t';
break; break;
case 'u' : // Unicode case 'u' : // Unicode
{ {
@ -196,7 +197,11 @@ public:
{ {
throw JSONException("Invalid unicode"); throw JSONException("Invalid unicode");
} }
c = unicode; //unicode to utf8
std::string utf8;
UnicodeConverter::toUTF8((const UTF32Char*)&unicode,1,utf8);
_value += utf8;
break; break;
} }
default: default:
@ -204,8 +209,9 @@ public:
throw JSONException(format("Invalid escape '%c' character used", (char) c)); throw JSONException(format("Invalid escape '%c' character used", (char) c));
} }
} }
}else{
_value += c;
} }
_value += c;
c = istr.get(); c = istr.get();
} }

View File

@ -859,6 +859,35 @@ void JSONTest::testTemplate()
} }
void JSONTest::testUnicode()
{
const unsigned char supp[] = {0x61, 0xE1, 0xE9, 0x78, 0xED, 0xF3, 0xFA, 0x0};
std::string text((const char*) supp);
std::string json = "{ \"test\" : \"a\u00E1\u00E9x\u00ED\u00F3\u00FA\" }";
Parser parser;
Var result;
try
{
DefaultHandler handler;
parser.setHandler(&handler);
parser.parse(json);
result = handler.result();
}
catch(JSONException& jsone)
{
std::cout << jsone.message() << std::endl;
assert(false);
}
assert(result.type() == typeid(Object::Ptr));
Object::Ptr object = result.extract<Object::Ptr>();
Var test = object->get("test");
assert(test.convert<std::string>() == text);
}
std::string JSONTest::getTestFilesPath(const std::string& type) std::string JSONTest::getTestFilesPath(const std::string& type)
{ {
std::ostringstream ostr; std::ostringstream ostr;
@ -918,6 +947,7 @@ CppUnit::Test* JSONTest::suite()
CppUnit_addTest(pSuite, JSONTest, testValidJanssonFiles); CppUnit_addTest(pSuite, JSONTest, testValidJanssonFiles);
CppUnit_addTest(pSuite, JSONTest, testInvalidJanssonFiles); CppUnit_addTest(pSuite, JSONTest, testInvalidJanssonFiles);
CppUnit_addTest(pSuite, JSONTest, testTemplate); CppUnit_addTest(pSuite, JSONTest, testTemplate);
CppUnit_addTest(pSuite, JSONTest, testUnicode);
return pSuite; return pSuite;
} }

View File

@ -76,6 +76,7 @@ public:
void testInvalidJanssonFiles(); void testInvalidJanssonFiles();
void testTemplate(); void testTemplate();
void testItunes(); void testItunes();
void testUnicode();
void setUp(); void setUp();
void tearDown(); void tearDown();