generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-12-13 18:17:12 +01:00
Code Issues Projects Releases Wiki Activity

feat(AsyncNotificationCenter): Auto-configure number of workers #5060 (#5061)

Browse Source 
* feat(AsyncNotificationCenter): Auto-configure number of workers #5060
add/removeObserver utility functions
move AsyncNotificationCenter tests into a separate file
tests

* chore: update copyrighht
This commit is contained in:
Aleksandar Fabijanic
2025-11-13 01:36:07 -06:00
committed by GitHub
parent 1284103b98
commit c775d5f3b7
19 changed files with 1047 additions and 422 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
Foundation/src/AsyncNotificationCenter.cpp
View File

@@ -6,7 +6,7 @@
// Module: AsyncNotificationCenter
//
// Copyright (c) 2004-2006, Applied Informatics Software Engineering GmbH.
// Aleph ONE Software Engineering d.o.o.,
// Aleph ONE Software Engineering LLC,
// and Contributors.
//
// SPDX-License-Identifier: BSL-1.0
@@ -26,6 +26,17 @@ namespace Poco {
#if (POCO_HAVE_JTHREAD)
AsyncNotificationCenter::AsyncNotificationCenter(AsyncMode mode) :
_mode(mode),
_ra(*this, &AsyncNotificationCenter::dequeue),
_enqueueThreadStarted(false),
_enqueueThreadDone(false),
_workersCount(defaultWorkersCount())
{
start();
}
AsyncNotificationCenter::AsyncNotificationCenter(AsyncMode mode, std::size_t workersCount) :
_mode(mode),
_ra(*this, &AsyncNotificationCenter::dequeue),
@@ -46,7 +57,7 @@ AsyncNotificationCenter::AsyncNotificationCenter() :
start();
}
#endif
#endif // POCO_HAVE_JTHREAD
AsyncNotificationCenter::~AsyncNotificationCenter()
{
@@ -54,6 +65,20 @@ AsyncNotificationCenter::~AsyncNotificationCenter()
}
#if (POCO_HAVE_JTHREAD)
std::size_t AsyncNotificationCenter::defaultWorkersCount()
{
unsigned int cores = std::thread::hardware_concurrency();
if (cores <= 2) return 2;
else if (cores <= 4) return 3;
else if (cores <= 8) return 4;
else return 6;
}
#endif // POCO_HAVE_JTHREAD
void AsyncNotificationCenter::postNotification(Notification::Ptr pNotification)
{
#if (POCO_HAVE_JTHREAD)
@@ -108,8 +133,6 @@ void AsyncNotificationCenter::notifyObservers(Notification::Ptr& pNotification)
if (_mode == AsyncMode::NOTIFY || _mode == AsyncMode::BOTH)
{
// Notification is asynchronous, add it to the lists
// for appropriate observers.
std::unique_lock<std::mutex> lock(_listsMutex);
auto observers = observersToNotify(pNotification);
if (observers.empty())
@@ -121,15 +144,12 @@ void AsyncNotificationCenter::notifyObservers(Notification::Ptr& pNotification)
}
_listsEmpty = false;
_listsEmptyCondition.notify_all();
return;
}
else
{
// Notification is synchronous
NotificationCenter::notifyObservers(pNotification);
}
#else
#endif // POCO_HAVE_JTHREAD
NotificationCenter::notifyObservers(pNotification);
#endif
}
@@ -180,7 +200,6 @@ void AsyncNotificationCenter::stop()
{
if (_enqueueThreadStarted.exchange(false))
{
_nq.enqueueUrgentNotification(new ShutdownNotification);
_nq.wakeUpAll();
while (!_enqueueThreadDone) Thread::sleep(100);
_enqueueThread.join();
@@ -196,9 +215,6 @@ void AsyncNotificationCenter::stop()
{
if (t.joinable()) t.join();
}
// TODO: Should the observer lists be cleared here or
// shall the workers send all of them to observers and then finish?
#endif
}
@@ -208,11 +224,8 @@ void AsyncNotificationCenter::dequeue()
Notification::Ptr pNf;
_enqueueThreadStarted = true;
_enqueueThreadDone = false;
while (true)
while ((pNf = _nq.waitDequeueNotification()))
{
pNf = _nq.waitDequeueNotification();
if (!pNf) break;
if (pNf.cast<ShutdownNotification>()) break;
try
{
notifyObservers(pNf);