generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2024-12-13 10:32:57 +01:00
Code Issues Projects Releases Wiki Activity

fix(Process): CloseHandle() on an null/invalid handle will throw an exception in the debugger

Browse Source
This commit is contained in:
Günter Obiltschnig 2024-04-03 07:09:37 +02:00
parent e428c4b46c
commit a25cdac549
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Foundation/src/Process_WIN32U.cpp
View File

@ -280,7 +280,11 @@ ProcessHandleImpl* ProcessImpl::launchImpl(const std::string& command, const Arg
{
startupInfo.hStdInput = 0;
}
if (options & PROCESS_CLOSE_STDIN) CloseHandle(GetStdHandle(STD_INPUT_HANDLE));
if (options & PROCESS_CLOSE_STDIN)
{
HANDLE hStdIn = GetStdHandle(STD_INPUT_HANDLE);
if (hStdIn) CloseHandle(hStdIn);
}
// outPipe may be the same as errPipe, so we duplicate first and close later.
if (outPipe)
@ -312,9 +316,17 @@ ProcessHandleImpl* ProcessImpl::launchImpl(const std::string& command, const Arg
startupInfo.hStdError = 0;
}
if (outPipe) outPipe->close(Pipe::CLOSE_WRITE);
if (options & PROCESS_CLOSE_STDOUT) CloseHandle(GetStdHandle(STD_OUTPUT_HANDLE));
if (options & PROCESS_CLOSE_STDOUT)
{
HANDLE hStdOut = GetStdHandle(STD_OUTPUT_HANDLE);
if (hStdOut) CloseHandle(hStdOut);
}
if (errPipe) errPipe->close(Pipe::CLOSE_WRITE);
if (options & PROCESS_CLOSE_STDERR) CloseHandle(GetStdHandle(STD_ERROR_HANDLE));
if (options & PROCESS_CLOSE_STDERR)
{
HANDLE hStdErr = GetStdHandle(STD_ERROR_HANDLE);
if (hStdErr) CloseHandle(hStdErr);
}
if (mustInheritHandles)
{