generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-01-06 08:41:11 +01:00
Code Issues Projects Releases Wiki Activity

GH #1087: prevent line breaks in base64-encoded creds

Browse Source
This commit is contained in:
Guenter Obiltschnig 2015-12-16 09:23:40 +01:00
parent 899e5084e9
commit a0f797203e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Net/src/SMTPClientSession.cpp
View File

@ -148,6 +148,7 @@ void SMTPClientSession::loginUsingCRAM(const std::string& username, const std::s
std::ostringstream challengeResponseBase64; std::ostringstream challengeResponseBase64;
Base64Encoder encoder(challengeResponseBase64); Base64Encoder encoder(challengeResponseBase64);
encoder.rdbuf()->setLineLength(0);
encoder << challengeResponse; encoder << challengeResponse;
encoder.close(); encoder.close();
@ -164,11 +165,13 @@ void SMTPClientSession::loginUsingLogin(const std::string& username, const std::
std::ostringstream usernameBase64; std::ostringstream usernameBase64;
Base64Encoder usernameEncoder(usernameBase64); Base64Encoder usernameEncoder(usernameBase64);
usernameEncoder.rdbuf()->setLineLength(0);
usernameEncoder << username; usernameEncoder << username;
usernameEncoder.close(); usernameEncoder.close();
std::ostringstream passwordBase64; std::ostringstream passwordBase64;
Base64Encoder passwordEncoder(passwordBase64); Base64Encoder passwordEncoder(passwordBase64);
passwordEncoder.rdbuf()->setLineLength(0);
passwordEncoder << password; passwordEncoder << password;
passwordEncoder.close(); passwordEncoder.close();
@ -211,6 +214,7 @@ void SMTPClientSession::loginUsingPlain(const std::string& username, const std::
{ {
std::ostringstream credentialsBase64; std::ostringstream credentialsBase64;
Base64Encoder credentialsEncoder(credentialsBase64); Base64Encoder credentialsEncoder(credentialsBase64);
credentialsEncoder.rdbuf()->setLineLength(0);
credentialsEncoder << '\0' << username << '\0' << password; credentialsEncoder << '\0' << username << '\0' << password;
credentialsEncoder.close(); credentialsEncoder.close();
@ -224,6 +228,7 @@ void SMTPClientSession::loginUsingXOAUTH2(const std::string& username, const std
{ {
std::ostringstream credentialsBase64; std::ostringstream credentialsBase64;
Base64Encoder credentialsEncoder(credentialsBase64); Base64Encoder credentialsEncoder(credentialsBase64);
credentialsEncoder.rdbuf()->setLineLength(0);
credentialsEncoder << "user=" << username << "\001auth=Bearer " << password << "\001\001"; credentialsEncoder << "user=" << username << "\001auth=Bearer " << password << "\001\001";
credentialsEncoder.close(); credentialsEncoder.close();