From 8d4ec98052d5ec3623cb1e50921305f8b06583f6 Mon Sep 17 00:00:00 2001
From: nyashbox <nyashbox@tutanota.com>
Date: Tue, 3 Dec 2024 15:19:43 +0200
Subject: [PATCH] test(Zip): add archive consistency tests

---
 Zip/testsuite/data/consistency-crc32.zip      | Bin 0 -> 171 bytes
 .../data/consistency-uncompressed.zip         | Bin 0 -> 171 bytes
 Zip/testsuite/src/ZipTest.cpp                 |  56 ++++++++++++++++++
 Zip/testsuite/src/ZipTest.h                   |   1 +
 4 files changed, 57 insertions(+)
 create mode 100644 Zip/testsuite/data/consistency-crc32.zip
 create mode 100644 Zip/testsuite/data/consistency-uncompressed.zip

diff --git a/Zip/testsuite/data/consistency-crc32.zip b/Zip/testsuite/data/consistency-crc32.zip
new file mode 100644
index 0000000000000000000000000000000000000000..0872da56292360bdab7fd9cb92bda32992694ee7
GIT binary patch
literal 171
zcmWIWW@h1H00Aw@=Ezk*zzSr8Fb9JSLrP*vqFzZwNoWWs1G7VvU%Dj_msW5yFtWU0
zW?%pliAl*RTmjyUOmfT!gVrqRia;170WzO~5r~&Gf>;P+Ss})v85!Ws$_7%$2!wt>
J+8xAU001Wt9wz_*

literal 0
HcmV?d00001

diff --git a/Zip/testsuite/data/consistency-uncompressed.zip b/Zip/testsuite/data/consistency-uncompressed.zip
new file mode 100644
index 0000000000000000000000000000000000000000..ff034f867dccf4b4b9ed01dc629a85ebd2d9cbd6
GIT binary patch
literal 171
zcmWIWW@h1H00Aw@=EyZmx*}MC>{UR_!63tsl30?cS5i?D8p6rI>=5Ob9t^~#72FJr
zEH9WD7{EkgQgRAcfHxzP95bdtAj3EqB!DCX10xVGX#}wl#<D_;MKdzMo0Scuju8m`
KfV4Y^!vFwGj~;LU

literal 0
HcmV?d00001

diff --git a/Zip/testsuite/src/ZipTest.cpp b/Zip/testsuite/src/ZipTest.cpp
index e16f3da15..d306660eb 100644
--- a/Zip/testsuite/src/ZipTest.cpp
+++ b/Zip/testsuite/src/ZipTest.cpp
@@ -11,6 +11,7 @@
 #include "ZipTest.h"
 #include "Poco/Zip/SkipCallback.h"
 #include "Poco/Zip/ZipLocalFileHeader.h"
+#include "Poco/Zip/ZipException.h"
 #include "Poco/Zip/ZipArchive.h"
 #include "Poco/Zip/ZipStream.h"
 #include "Poco/Zip/Decompress.h"
@@ -287,6 +288,60 @@ void ZipTest::testDecompressZip64()
 }
 
 
+void ZipTest::testDecompressConsistency()
+{
+	// test archives with borked file headers, but correct directory
+	const std::string testArchives[] =
+	{
+		"consistency-crc32.zip",
+		"consistency-uncompressed.zip"
+	};
+
+
+	for (const std::string &archive : testArchives)
+	{
+		//
+		// test decompressing all files
+		//
+		{
+			Poco::FileInputStream inputStream(getTestFile("data", archive));
+			assertTrue (inputStream.good());
+
+			Decompress dec(inputStream, Poco::Path::temp());
+
+			try {
+				dec.decompressAllFiles();
+				assertTrue (false);
+			}
+			catch (const ZipException &e)
+			{
+			}
+		}
+
+
+		//
+		// test decompressing single file
+		//
+		{
+			Poco::FileInputStream inputStream(getTestFile("data", archive));
+			assertTrue (inputStream.good());
+
+			ZipArchive archive(inputStream);
+
+			// File decompression code is skipped since
+			// we are not expecting archive to be processed further
+			try
+			{
+				archive.checkConsistency();
+				assertTrue (false);
+			}
+			catch (const ZipException &e)
+			{
+			}
+		}
+	};
+}
+
 void ZipTest::testValidPath()
 {
 	assertTrue (ZipCommon::isValidPath("."));
@@ -357,6 +412,7 @@ CppUnit::Test* ZipTest::suite()
 	CppUnit_addTest(pSuite, ZipTest, testCrcAndSizeAfterDataEncapsulated);
 	CppUnit_addTest(pSuite, ZipTest, testDecompressZip64);
 	CppUnit_addTest(pSuite, ZipTest, testValidPath);
+	CppUnit_addTest(pSuite, ZipTest, testDecompressConsistency);
 
 	return pSuite;
 }
diff --git a/Zip/testsuite/src/ZipTest.h b/Zip/testsuite/src/ZipTest.h
index cd77baaae..fa4971525 100644
--- a/Zip/testsuite/src/ZipTest.h
+++ b/Zip/testsuite/src/ZipTest.h
@@ -29,6 +29,7 @@ public:
 	void testDecompressSingleFile();
 	void testDecompressSingleFileInDir();
 	void testDecompress();
+	void testDecompressConsistency();
 	void testDecompressFlat();
 	void testDecompressVuln();
 	void testDecompressFlatVuln();