#538 prevent destructors from throwing exceptions

Data/MySQL/include/Poco/Data/MySQL/Connector.h

@@ -84,9 +84,16 @@ struct MySQL_API MySQLConnectorRegistrator
 
 	~MySQLConnectorRegistrator()
 		/// Calls Poco::Data::MySQL::unregisterConnector();
+	{
+		try
 		{
 			Poco::Data::MySQL::Connector::unregisterConnector();
 		}
+		catch (...)
+		{
+			poco_unexpected();
+		}
+	}
 };
 
 

Data/ODBC/include/Poco/Data/ODBC/Connector.h

@@ -95,9 +95,16 @@ struct ODBC_API ODBCConnectorRegistrator
 
 	~ODBCConnectorRegistrator()
 		/// Calls Poco::Data::ODBC::unregisterConnector();
+	{
+		try
 		{
 			Poco::Data::ODBC::Connector::unregisterConnector();
 		}
+		catch (...)
+		{
+			poco_unexpected();
+		}
+	}
 };
 
 

Data/ODBC/include/Poco/Data/ODBC/Handle.h

@@ -57,6 +57,8 @@ public:
 	~Handle()
 		/// Destroys the Handle.
 	{
+		try
+		{
 #if defined(_DEBUG)
 			SQLRETURN rc = 
 #endif
@@ -65,6 +67,11 @@ public:
 			// leak resources. So, we throw here in debug mode if things go bad.
 			poco_assert_dbg (!Utility::isError(rc));
 		}
+		catch (...)
+		{
+			poco_unexpected();
+		}
+	}
 
 	operator const H& () const
 		/// Const conversion operator into reference to native type.

Data/ODBC/src/ConnectionHandle.cpp

@@ -39,6 +39,8 @@ ConnectionHandle::ConnectionHandle(EnvironmentHandle* pEnvironment):
 
 
 ConnectionHandle::~ConnectionHandle()
+{
+	try
 	{
 		SQLDisconnect(_hdbc);
 		SQLRETURN rc = SQLFreeHandle(SQL_HANDLE_DBC, _hdbc);
@@ -47,6 +49,11 @@ ConnectionHandle::~ConnectionHandle()
 
 		poco_assert (!Utility::isError(rc));
 	}
+	catch (...)
+	{
+		poco_unexpected();
+	}
+}
 
 
 } } } // namespace Poco::Data::ODBC

Data/ODBC/src/EnvironmentHandle.cpp

@@ -40,10 +40,17 @@ EnvironmentHandle::EnvironmentHandle(): _henv(SQL_NULL_HENV)
 
 
 EnvironmentHandle::~EnvironmentHandle()
+{
+	try
 	{
 		SQLRETURN rc = SQLFreeHandle(SQL_HANDLE_ENV, _henv);
 		poco_assert (!Utility::isError(rc));
 	}
+	catch (...)
+	{
+		poco_unexpected();
+	}
+}
 
 
 } } } // namespace Poco::Data::ODBC

Data/ODBC/src/Preparator.cpp

@@ -51,9 +51,16 @@ Preparator::Preparator(const Preparator& other):
 
 
 Preparator::~Preparator()
+{
+	try
 	{
 		freeMemory();
 	}
+	catch (...)
+	{
+		poco_unexpected();
+	}
+}
 
 
 void Preparator::freeMemory() const

Data/ODBC/src/SessionImpl.cpp

@@ -69,6 +69,8 @@ SessionImpl::SessionImpl(const std::string& connect,
 
 
 SessionImpl::~SessionImpl()
+{
+	try
 	{
 		if (isTransaction() && !getFeature("autoCommit"))
 		{
@@ -76,8 +78,12 @@ SessionImpl::~SessionImpl()
 			catch (...) { }
 		}
 
-	try { close(); }
+		close();
-	catch (...) { }
+	}
+	catch (...)
+	{
+		poco_unexpected();
+	}
 }
 
 

Data/SQLite/include/Poco/Data/SQLite/Connector.h

@@ -103,9 +103,16 @@ struct SQLite_API SQLiteConnectorRegistrator
 
 	~SQLiteConnectorRegistrator()
 		/// Calls Poco::Data::SQLite::unregisterConnector();
+	{
+		try
 		{
 			Poco::Data::SQLite::Connector::unregisterConnector();
 		}
+		catch (...)
+		{
+			poco_unexpected();
+		}
+	}
 };
 
 

Data/SQLite/src/Notifier.cpp

@@ -44,9 +44,16 @@ Notifier::Notifier(const Session& session, const Any& value, EnabledEventType en
 
 
 Notifier::~Notifier()
+{
+	try
 	{
 		disableAll();
 	}
+	catch (...)
+	{
+		poco_unexpected();
+	}
+}
 
 
 bool Notifier::enableUpdate()

Data/SQLite/src/SQLiteStatementImpl.cpp

@@ -51,9 +51,16 @@ SQLiteStatementImpl::SQLiteStatementImpl(Poco::Data::SessionImpl& rSession, sqli
 	
 
 SQLiteStatementImpl::~SQLiteStatementImpl()
+{
+	try
 	{
 		clear();
 	}
+	catch (...)
+	{
+		poco_unexpected();
+	}
+}
 
 
 void SQLiteStatementImpl::compileImpl()

Data/SQLite/src/SessionImpl.cpp

@@ -56,9 +56,16 @@ SessionImpl::SessionImpl(const std::string& fileName, std::size_t loginTimeout):
 
 
 SessionImpl::~SessionImpl()
+{
+	try
 	{
 		close();
 	}
+	catch (...)
+	{
+		poco_unexpected();
+	}
+}
 
 
 Poco::Data::StatementImpl* SessionImpl::createStatementImpl()