mirror of
https://github.com/pocoproject/poco.git
synced 2025-10-30 05:29:41 +01:00
GH #1050 Data: fix gcc -Wshadow warnings
This commit is contained in:
@@ -82,8 +82,8 @@ RecordSet::~RecordSet()
|
||||
if(_pFilter) _pFilter->release();
|
||||
|
||||
RowMap::iterator it = _rowMap.begin();
|
||||
RowMap::iterator end = _rowMap.end();
|
||||
for (; it != end; ++it) delete it->second;
|
||||
RowMap::iterator itEnd = _rowMap.end();
|
||||
for (; it != itEnd; ++it) delete it->second;
|
||||
}
|
||||
catch (...)
|
||||
{
|
||||
@@ -92,65 +92,65 @@ RecordSet::~RecordSet()
|
||||
}
|
||||
|
||||
|
||||
Poco::Dynamic::Var RecordSet::value(std::size_t col, std::size_t row, bool useFilter) const
|
||||
Poco::Dynamic::Var RecordSet::value(std::size_t col, std::size_t dataRow, bool useFilter) const
|
||||
{
|
||||
if (useFilter && isFiltered() && !isAllowed(row))
|
||||
if (useFilter && isFiltered() && !isAllowed(dataRow))
|
||||
throw InvalidAccessException("Row not allowed");
|
||||
|
||||
if (isNull(col, row)) return Poco::Dynamic::Var();
|
||||
if (isNull(col, dataRow)) return Poco::Dynamic::Var();
|
||||
|
||||
switch (columnType(col))
|
||||
{
|
||||
case MetaColumn::FDT_BOOL: return value<bool>(col, row, useFilter);
|
||||
case MetaColumn::FDT_INT8: return value<Int8>(col, row, useFilter);
|
||||
case MetaColumn::FDT_UINT8: return value<UInt8>(col, row, useFilter);
|
||||
case MetaColumn::FDT_INT16: return value<Int16>(col, row, useFilter);
|
||||
case MetaColumn::FDT_UINT16: return value<UInt16>(col, row, useFilter);
|
||||
case MetaColumn::FDT_INT32: return value<Int32>(col, row, useFilter);
|
||||
case MetaColumn::FDT_UINT32: return value<UInt32>(col, row, useFilter);
|
||||
case MetaColumn::FDT_INT64: return value<Int64>(col, row, useFilter);
|
||||
case MetaColumn::FDT_UINT64: return value<UInt64>(col, row, useFilter);
|
||||
case MetaColumn::FDT_FLOAT: return value<float>(col, row, useFilter);
|
||||
case MetaColumn::FDT_DOUBLE: return value<double>(col, row, useFilter);
|
||||
case MetaColumn::FDT_STRING: return value<std::string>(col, row, useFilter);
|
||||
case MetaColumn::FDT_WSTRING: return value<UTF16String>(col, row, useFilter);
|
||||
case MetaColumn::FDT_BLOB: return value<BLOB>(col, row, useFilter);
|
||||
case MetaColumn::FDT_CLOB: return value<CLOB>(col, row, useFilter);
|
||||
case MetaColumn::FDT_DATE: return value<Date>(col, row, useFilter);
|
||||
case MetaColumn::FDT_TIME: return value<Time>(col, row, useFilter);
|
||||
case MetaColumn::FDT_TIMESTAMP: return value<DateTime>(col, row);
|
||||
case MetaColumn::FDT_BOOL: return value<bool>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_INT8: return value<Int8>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_UINT8: return value<UInt8>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_INT16: return value<Int16>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_UINT16: return value<UInt16>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_INT32: return value<Int32>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_UINT32: return value<UInt32>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_INT64: return value<Int64>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_UINT64: return value<UInt64>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_FLOAT: return value<float>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_DOUBLE: return value<double>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_STRING: return value<std::string>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_WSTRING: return value<UTF16String>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_BLOB: return value<BLOB>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_CLOB: return value<CLOB>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_DATE: return value<Date>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_TIME: return value<Time>(col, dataRow, useFilter);
|
||||
case MetaColumn::FDT_TIMESTAMP: return value<DateTime>(col, dataRow);
|
||||
default:
|
||||
throw UnknownTypeException("Data type not supported.");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Poco::Dynamic::Var RecordSet::value(const std::string& name, std::size_t row, bool useFilter) const
|
||||
Poco::Dynamic::Var RecordSet::value(const std::string& name, std::size_t dataRow, bool useFilter) const
|
||||
{
|
||||
if (useFilter && isFiltered() && !isAllowed(row))
|
||||
if (useFilter && isFiltered() && !isAllowed(dataRow))
|
||||
throw InvalidAccessException("Row not allowed");
|
||||
|
||||
if (isNull(metaColumn(name).position(), row)) return Poco::Dynamic::Var();
|
||||
if (isNull(metaColumn(name).position(), dataRow)) return Poco::Dynamic::Var();
|
||||
|
||||
switch (columnType(name))
|
||||
{
|
||||
case MetaColumn::FDT_BOOL: return value<bool>(name, row, useFilter);
|
||||
case MetaColumn::FDT_INT8: return value<Int8>(name, row, useFilter);
|
||||
case MetaColumn::FDT_UINT8: return value<UInt8>(name, row, useFilter);
|
||||
case MetaColumn::FDT_INT16: return value<Int16>(name, row, useFilter);
|
||||
case MetaColumn::FDT_UINT16: return value<UInt16>(name, row, useFilter);
|
||||
case MetaColumn::FDT_INT32: return value<Int32>(name, row, useFilter);
|
||||
case MetaColumn::FDT_UINT32: return value<UInt32>(name, row, useFilter);
|
||||
case MetaColumn::FDT_INT64: return value<Int64>(name, row, useFilter);
|
||||
case MetaColumn::FDT_UINT64: return value<UInt64>(name, row, useFilter);
|
||||
case MetaColumn::FDT_FLOAT: return value<float>(name, row, useFilter);
|
||||
case MetaColumn::FDT_DOUBLE: return value<double>(name, row, useFilter);
|
||||
case MetaColumn::FDT_STRING: return value<std::string>(name, row, useFilter);
|
||||
case MetaColumn::FDT_WSTRING: return value<UTF16String>(name, row, useFilter);
|
||||
case MetaColumn::FDT_BLOB: return value<BLOB>(name, row, useFilter);
|
||||
case MetaColumn::FDT_DATE: return value<Date>(name, row, useFilter);
|
||||
case MetaColumn::FDT_TIME: return value<Time>(name, row, useFilter);
|
||||
case MetaColumn::FDT_TIMESTAMP: return value<DateTime>(name, row, useFilter);
|
||||
case MetaColumn::FDT_BOOL: return value<bool>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_INT8: return value<Int8>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_UINT8: return value<UInt8>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_INT16: return value<Int16>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_UINT16: return value<UInt16>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_INT32: return value<Int32>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_UINT32: return value<UInt32>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_INT64: return value<Int64>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_UINT64: return value<UInt64>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_FLOAT: return value<float>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_DOUBLE: return value<double>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_STRING: return value<std::string>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_WSTRING: return value<UTF16String>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_BLOB: return value<BLOB>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_DATE: return value<Date>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_TIME: return value<Time>(name, dataRow, useFilter);
|
||||
case MetaColumn::FDT_TIMESTAMP: return value<DateTime>(name, dataRow, useFilter);
|
||||
default:
|
||||
throw UnknownTypeException("Data type not supported.");
|
||||
}
|
||||
@@ -205,19 +205,19 @@ std::size_t RecordSet::rowCount() const
|
||||
if (!isFiltered()) return rc;
|
||||
|
||||
std::size_t counter = 0;
|
||||
for (int row = 0; row < rc; ++row)
|
||||
for (int dataRow = 0; dataRow < rc; ++dataRow)
|
||||
{
|
||||
if (isAllowed(row)) ++counter;
|
||||
if (isAllowed(dataRow)) ++counter;
|
||||
}
|
||||
|
||||
return counter;
|
||||
}
|
||||
|
||||
|
||||
bool RecordSet::isAllowed(std::size_t row) const
|
||||
bool RecordSet::isAllowed(std::size_t dataRow) const
|
||||
{
|
||||
if (!isFiltered()) return true;
|
||||
return _pFilter->isAllowed(row);
|
||||
return _pFilter->isAllowed(dataRow);
|
||||
}
|
||||
|
||||
|
||||
@@ -308,8 +308,8 @@ void RecordSet::setRowFormatter(RowFormatter::Ptr pRowFormatter)
|
||||
|
||||
Statement::setRowFormatter(pRowFormatter);
|
||||
RowMap::iterator it = _rowMap.begin();
|
||||
RowMap::iterator end = _rowMap.end();
|
||||
for (; it != end; ++it) it->second->setFormatter(getRowFormatter());
|
||||
RowMap::iterator itEnd = _rowMap.end();
|
||||
for (; it != itEnd; ++it) it->second->setFormatter(getRowFormatter());
|
||||
}
|
||||
else
|
||||
throw NullPointerException("Null RowFormatter in RecordSet.");
|
||||
@@ -331,8 +331,8 @@ std::ostream& RecordSet::copyValues(std::ostream& os, std::size_t offset, std::s
|
||||
if (begin() == end()) return os;
|
||||
|
||||
RowIterator it = *_pBegin + offset;
|
||||
RowIterator end = (RowIterator::POSITION_END != length) ? it + length : *_pEnd;
|
||||
std::copy(it, end, std::ostream_iterator<Row>(os));
|
||||
RowIterator itEnd = (RowIterator::POSITION_END != length) ? it + length : *_pEnd;
|
||||
std::copy(it, itEnd, std::ostream_iterator<Row>(os));
|
||||
return os;
|
||||
}
|
||||
|
||||
@@ -342,9 +342,9 @@ void RecordSet::formatValues(std::size_t offset, std::size_t length) const
|
||||
if (begin() == end()) return;
|
||||
|
||||
RowIterator it = *_pBegin + offset;
|
||||
RowIterator end = (RowIterator::POSITION_END != length) ? it + length : *_pEnd;
|
||||
RowIterator itEnd = (RowIterator::POSITION_END != length) ? it + length : *_pEnd;
|
||||
std::string val;
|
||||
for (; it != end; ++it) it->formatValues();
|
||||
for (; it != itEnd; ++it) it->formatValues();
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user