generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-05-03 15:58:23 +02:00
Code Issues Projects Releases Wiki Activity

UDPHandler: don't use SpinlockMutex, due to poor performance on single-core systems; make Mutex class a template param instead

Browse Source
This commit is contained in:
Günter Obiltschnig 2023-10-15 10:16:52 +02:00
parent 06a03d1ada
commit 6385a3c86e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Net/include/Poco/Net/UDPHandler.h
View File

@ -41,7 +41,7 @@ typedef int UDPMsgSizeT;
#define POCO_UDP_BUF_SIZE 1472 + sizeof(UDPMsgSizeT) + SocketAddress::MAX_ADDRESS_LENGTH #define POCO_UDP_BUF_SIZE 1472 + sizeof(UDPMsgSizeT) + SocketAddress::MAX_ADDRESS_LENGTH
template <std::size_t S = POCO_UDP_BUF_SIZE> template <std::size_t S = POCO_UDP_BUF_SIZE, class TMutex = Poco::FastMutex>
class UDPHandlerImpl: public Runnable, public RefCountedObject class UDPHandlerImpl: public Runnable, public RefCountedObject
/// UDP handler handles the data that arrives to the UDP server. /// UDP handler handles the data that arrives to the UDP server.
/// The class is thread-safe and runs in its own thread, so many handlers /// The class is thread-safe and runs in its own thread, so many handlers
@ -57,7 +57,7 @@ public:
typedef AutoPtr<UDPHandlerImpl> Ptr; typedef AutoPtr<UDPHandlerImpl> Ptr;
typedef std::vector<Ptr> List; typedef std::vector<Ptr> List;
typedef typename List::iterator Iterator; typedef typename List::iterator Iterator;
typedef Poco::FastMutex DFMutex; typedef TMutex DFMutex;
static const MsgSizeT BUF_STATUS_IDLE = 0; static const MsgSizeT BUF_STATUS_IDLE = 0;
static const MsgSizeT BUF_STATUS_BUSY = -1; static const MsgSizeT BUF_STATUS_BUSY = -1;
@ -244,14 +244,14 @@ public:
bool hasData(char*& pBuf) bool hasData(char*& pBuf)
/// Returns true if buffer contains data. /// Returns true if buffer contains data.
{ {
DFMutex::ScopedLock l(_dfMutex); typename DFMutex::ScopedLock l(_dfMutex);
return *reinterpret_cast<MsgSizeT*>(pBuf) > 0; return *reinterpret_cast<MsgSizeT*>(pBuf) > 0;
} }
bool isError(char*& pBuf) bool isError(char*& pBuf)
/// Returns true if buffer contains error. /// Returns true if buffer contains error.
{ {
DFMutex::ScopedLock l(_dfMutex); typename DFMutex::ScopedLock l(_dfMutex);
return *reinterpret_cast<MsgSizeT*>(pBuf) == BUF_STATUS_ERROR; return *reinterpret_cast<MsgSizeT*>(pBuf) == BUF_STATUS_ERROR;
} }
@ -349,7 +349,7 @@ private:
void setStatus(char*& pBuf, MsgSizeT status) void setStatus(char*& pBuf, MsgSizeT status)
{ {
DFMutex::ScopedLock l(_dfMutex); typename DFMutex::ScopedLock l(_dfMutex);
setStatusImpl(pBuf, status); setStatusImpl(pBuf, status);
} }