generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-04-19 15:47:14 +02:00
Code Issues Projects Releases Wiki Activity

Fix race condition in TCPServerDispatcher.cpp

Browse Source
This commit is contained in:
Conor Burgess 2018-01-12 18:11:31 +00:00 committed by Günter Obiltschnig
parent 7eb1325bba
commit 603a6e23da
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Net/src/TCPServerDispatcher.cpp
View File

@ -96,7 +96,7 @@ void TCPServerDispatcher::release()
void TCPServerDispatcher::run()
{
AutoPtr<TCPServerDispatcher> guard(this, true); // ensure object stays alive
AutoPtr<TCPServerDispatcher> guard(this, false); // ensure _rc is decreased when function exits
int idleTime = (int) _pParams->getThreadIdleTime().totalMilliseconds();
@ -149,6 +149,10 @@ void TCPServerDispatcher::enqueue(const StreamSocket& socket)
{
_threadPool.startWithPriority(_pParams->getThreadPriority(), *this, threadName);
++_currentThreads;
// Ensure this object lives at least until run() starts
// Small chance of leaking if threadpool is stopped before this
// work runs, but better than a dangling pointer and crash!
duplicate();
}
catch (Poco::Exception&)
{