generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-04-17 07:13:27 +02:00
Code Issues Projects Releases Wiki Activity

fix(ICMPv4Packet): [asan] Undefined behavior in ICMPv4PacketImpl.cpp #3326

Browse Source
This commit is contained in:
Alex Fabijanic 2021-06-25 20:07:55 +02:00
parent 52e0581edc
commit 4ec21a62c2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Net/src/ICMPv4PacketImpl.cpp
View File

@ -156,8 +156,8 @@ struct timeval ICMPv4PacketImpl::time(Poco::UInt8* buffer, int length) const
}
else
{
struct timeval* ptv = (struct timeval*) data(buffer, length);
if (ptv) tv = *ptv;
struct timeval* ptv = reinterpret_cast<struct timeval*>(data(buffer, length));
if (ptv) std::memcpy(&tv, ptv, sizeof(tv));
else throw InvalidArgumentException("Invalid packet.");
}
return tv;
@ -172,13 +172,13 @@ ICMPv4PacketImpl::Header* ICMPv4PacketImpl::header(Poco::UInt8* buffer, int leng
if ((offset + sizeof(Header)) > length) return 0;
buffer += offset;
return (Header *) buffer;
return reinterpret_cast<Header*>(buffer);
}
Poco::UInt8* ICMPv4PacketImpl::data(Poco::UInt8* buffer, int length) const
{
return ((Poco::UInt8*) header(buffer, length)) + sizeof(Header);
return (reinterpret_cast<Poco::UInt8*>(header(buffer, length))) + sizeof(Header);
}