generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-10-24 17:30:44 +02:00
Code Issues Projects Releases Wiki Activity

Dynamic::Var SOO

Browse Source 
Dynamic::Var  small object optimization and some refactoring
This commit is contained in:
aleks-f
2013-02-05 22:12:21 -06:00
parent 54a92c59e5
commit 21da0129b6
16 changed files with 401 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
Foundation/src/Var.cpp
View File

@@ -44,35 +44,64 @@ namespace Poco {
namespace Dynamic {
Var::Var(): _pHolder(0)
Var::Var()
#ifdef POCO_NO_SOO
: _pHolder(0)
#endif
{
}
Var::Var(const char* pVal):
_pHolder(new VarHolderImpl<std::string>(pVal))
Var::Var(const char* pVal)
#ifdef POCO_NO_SOO
: _pHolder(new VarHolderImpl<std::string>(pVal)) { }
#else
{
construct(std::string(pVal));
}
#endif
Var::Var(const Var& other):
_pHolder(0)
Var::Var(const Var& other)
#ifdef POCO_NO_SOO
: _pHolder(0)
{
if (other._pHolder)
_pHolder = other._pHolder->clone();
}
#else
{
if ((this != &other) && !other.isEmpty())
construct(other);
}
#endif
Var::~Var()
{
delete _pHolder;
if(!isEmpty())
{
#ifndef POCO_NO_SOO
if(_placeholder.isLocal())
content()->~VarHolder();
else
#endif
delete content();
}
}
Var& Var::operator = (const Var& other)
Var& Var::operator = (const Var& rhs)
{
Var tmp(other);
#ifdef POCO_NO_SOO
Var tmp(rhs);
swap(tmp);
#else
if ((this != &rhs) && !rhs.isEmpty())
construct(rhs);
else if ((this != &rhs) && rhs.isEmpty())
_placeholder.erase();
#endif
return *this;
}
@@ -320,8 +349,14 @@ bool Var::operator && (const Var& other) const
void Var::empty()
{
#ifdef POCO_NO_SOO
delete _pHolder;
_pHolder = 0;
#else
if (_placeholder.isLocal()) this->~Var();
else delete content();
_placeholder.erase();
#endif
}