generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-03-03 04:38:39 +01:00
Code Issues Projects Releases Wiki Activity

fix(MongoDB): PooledConnection shall have a pointer to a ConnectionPool instead of a reference (fixes clang warning) #4276

Browse Source
This commit is contained in:
Matej Kenda 2023-11-30 12:46:24 +01:00
parent 4cfa96c94e
commit 1e4c08b4eb
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
MongoDB/include/Poco/MongoDB/PoolableConnectionFactory.h
View File

@ -89,11 +89,13 @@ namespace MongoDB {
class PooledConnection class PooledConnection
/// Helper class for borrowing and returning a connection automatically from a pool. /// Helper class for borrowing and returning a connection automatically from a pool.
/// Note that the connection pool is not expected to be deleted during the lifetime
/// of an instance of PooledConnection.
{ {
public: public:
PooledConnection(Poco::ObjectPool<Connection, Connection::Ptr>& pool) : _pool(pool) PooledConnection(Poco::ObjectPool<Connection, Connection::Ptr>& pool) : _pool(&pool)
{ {
_connection = _pool.borrowObject(); _connection = _pool->borrowObject();
} }
virtual ~PooledConnection() virtual ~PooledConnection()
@ -102,7 +104,7 @@ public:
{ {
if (_connection) if (_connection)
{ {
_pool.returnObject(_connection); _pool->returnObject(_connection);
} }
} }
catch (...) catch (...)
@ -125,7 +127,7 @@ public:
PooledConnection& operator=(PooledConnection&&) = default; PooledConnection& operator=(PooledConnection&&) = default;
private: private:
Poco::ObjectPool<Connection, Connection::Ptr>& _pool; Poco::ObjectPool<Connection, Connection::Ptr>* _pool;
Connection::Ptr _connection; Connection::Ptr _connection;
}; };