generic-library/poco
1
0
Fork 0
mirror of https://github.com/pocoproject/poco.git synced 2025-01-06 00:31:10 +01:00
Code Issues Projects Releases Wiki Activity

fixed GH #2106: Undefined behavior in Delegate::equals()

Browse Source
This commit is contained in:
Günter Obiltschnig 2018-03-06 18:26:49 +01:00
parent d73bb2ea86
commit 0d3c3ce4d4
1 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Foundation/include/Poco/Delegate.h
View File

@ -74,7 +74,7 @@ public:
bool equals(const AbstractDelegate<TArgs>& other) const bool equals(const AbstractDelegate<TArgs>& other) const
{ {
const Delegate* pOtherDelegate = reinterpret_cast<const Delegate*>(other.unwrap()); const Delegate* pOtherDelegate = dynamic_cast<const Delegate*>(other.unwrap());
return pOtherDelegate && _receiverObject == pOtherDelegate->_receiverObject && _receiverMethod == pOtherDelegate->_receiverMethod; return pOtherDelegate && _receiverObject == pOtherDelegate->_receiverObject && _receiverMethod == pOtherDelegate->_receiverMethod;
} }
@ -145,7 +145,7 @@ public:
bool equals(const AbstractDelegate<TArgs>& other) const bool equals(const AbstractDelegate<TArgs>& other) const
{ {
const Delegate* pOtherDelegate = reinterpret_cast<const Delegate*>(other.unwrap()); const Delegate* pOtherDelegate = dynamic_cast<const Delegate*>(other.unwrap());
return pOtherDelegate && _receiverObject == pOtherDelegate->_receiverObject && _receiverMethod == pOtherDelegate->_receiverMethod; return pOtherDelegate && _receiverObject == pOtherDelegate->_receiverObject && _receiverMethod == pOtherDelegate->_receiverMethod;
} }
@ -286,7 +286,7 @@ public:
bool equals(const AbstractDelegate<void>& other) const bool equals(const AbstractDelegate<void>& other) const
{ {
const Delegate* pOtherDelegate = reinterpret_cast<const Delegate*>(other.unwrap()); const Delegate* pOtherDelegate = dynamic_cast<const Delegate*>(other.unwrap());
return pOtherDelegate && _receiverObject == pOtherDelegate->_receiverObject && _receiverMethod == pOtherDelegate->_receiverMethod; return pOtherDelegate && _receiverObject == pOtherDelegate->_receiverObject && _receiverMethod == pOtherDelegate->_receiverMethod;
} }
@ -357,7 +357,7 @@ public:
bool equals(const AbstractDelegate<void>& other) const bool equals(const AbstractDelegate<void>& other) const
{ {
const Delegate* pOtherDelegate = reinterpret_cast<const Delegate*>(other.unwrap()); const Delegate* pOtherDelegate = dynamic_cast<const Delegate*>(other.unwrap());
return pOtherDelegate && _receiverObject == pOtherDelegate->_receiverObject && _receiverMethod == pOtherDelegate->_receiverMethod; return pOtherDelegate && _receiverObject == pOtherDelegate->_receiverObject && _receiverMethod == pOtherDelegate->_receiverMethod;
} }