openssl

History

Hanno Böck 2b8dc08b74 Call of memcmp with null pointers in obj_cmp()

The function obj_cmp() (file crypto/objects/obj_dat.c) can in some
situations call memcmp() with a null pointer and a zero length.

This is invalid behaviour. When compiling openssl with undefined
behaviour sanitizer (add -fsanitize=undefined to compile flags) this
can be seen. One example that triggers this behaviour is the pkcs7
command (but there are others, e.g. I've seen it with the timestamp
function):
apps/openssl pkcs7 -in test/testp7.pem

What happens is that obj_cmp takes objects of the type ASN1_OBJECT and
passes their ->data pointer to memcmp. Zero-sized ASN1_OBJECT
structures can have a null pointer as data.

RT#3816

Signed-off-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>

2015-05-13 15:23:57 +01:00

Makefile

Use safer sizeof variant in malloc

2015-05-04 15:00:13 -04:00

o_names.c

Use safer sizeof variant in malloc

2015-05-04 15:00:13 -04:00

obj_dat.c

Call of memcmp with null pointers in obj_cmp()

2015-05-13 15:23:57 +01:00

obj_dat.h

make update