generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix BN_[pseudo_]rand: 'mask' must be used even if top=-1.

Browse Source 
Mention BN_[pseudo_]rand with top=-1 in CHANGES.
This commit is contained in:
Bodo Möller 2001-02-20 08:10:38 +00:00
parent 8120813066
commit f2bc668429
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@ -113,6 +113,9 @@
*) Add new function BN_rand_range(), and fix DSA_sign_setup() to prevent *) Add new function BN_rand_range(), and fix DSA_sign_setup() to prevent
Bleichenbacher's DSA attack. Bleichenbacher's DSA attack.
Extend BN_[pseudo_]rand: As before, top=1 forces the highest two bits
to be set and top=0 forces the highest bit to be set; top=-1 is new
and leaves the highest bit random.
[Ulf Moeller, Bodo Moeller] [Ulf Moeller, Bodo Moeller]
*) Update Rijndael code to version 3.0 and change EVP AES ciphers to *) Update Rijndael code to version 3.0 and change EVP AES ciphers to

7
crypto/bn/bn_rand.c
View File

@ -76,7 +76,7 @@ static int bnrand(int pseudorand, BIGNUM *rnd, int bits, int top, int bottom)
bytes=(bits+7)/8; bytes=(bits+7)/8;
bit=(bits-1)%8; bit=(bits-1)%8;
mask=0xff<<bit; mask=0xff<<(bit+1);
buf=(unsigned char *)OPENSSL_malloc(bytes); buf=(unsigned char *)OPENSSL_malloc(bytes);
if (buf == NULL) if (buf == NULL)
@ -133,16 +133,15 @@ static int bnrand(int pseudorand, BIGNUM *rnd, int bits, int top, int bottom)
else else
{ {
buf[0]|=(3<<(bit-1)); buf[0]|=(3<<(bit-1));
buf[0]&= ~(mask<<1);
} }
} }
else else
{ {
buf[0]|=(1<<bit); buf[0]|=(1<<bit);
buf[0]&= ~(mask<<1);
} }
} }
if (bottom) /* set bottom bits to whatever odd is */ buf[0] &= ~mask;
if (bottom) /* set bottom bit if requested */
buf[bytes-1]|=1; buf[bytes-1]|=1;
if (!BN_bin2bn(buf,bytes,rnd)) goto err; if (!BN_bin2bn(buf,bytes,rnd)) goto err;
ret=1; ret=1;