generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add sanity check to print_bin function

Browse Source 
Add a sanity check to the print_bin function to ensure that the |off|
argument is positive. Thanks to Kevin Wojtysiak (Int3 Solutions) and
Paramjot Oberoi (Int3 Solutions) for reporting this issue.

Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit 3deeeeb61b)
This commit is contained in:
Matt Caswell 2015-04-29 09:58:10 +01:00
parent 39b36cb438
commit ee900ed1f7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/ec/eck_prn.c
View File

@ -338,12 +338,14 @@ static int print_bin(BIO *fp, const char *name, const unsigned char *buf,
if (buf == NULL) if (buf == NULL)
return 1; return 1;
if (off) { if (off > 0) {
if (off > 128) if (off > 128)
off = 128; off = 128;
memset(str, ' ', off); memset(str, ' ', off);
if (BIO_write(fp, str, off) <= 0) if (BIO_write(fp, str, off) <= 0)
return 0; return 0;
} else {
off = 0;
} }
if (BIO_printf(fp, "%s", name) <= 0) if (BIO_printf(fp, "%s", name) <= 0)