generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix a memory leak in BIO_get_accept_socket(). This leak was small and

Browse Source 
only happened when the port number wasn't parsable ot the host wasn't
possible to convert to an IP address.
Contributed by Niko Baric <Niko.Baric@epost.de>
This commit is contained in:
Richard Levitte 2001-02-05 09:15:09 +00:00
parent 448361a86c
commit e24e40657f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crypto/bio/b_sock.c
View File

@ -519,10 +519,10 @@ int BIO_get_accept_socket(char *host, int bind_mode)
{ {
int ret=0; int ret=0;
struct sockaddr_in server,client; struct sockaddr_in server,client;
int s= -1,cs; int s=INVALID_SOCKET,cs;
unsigned char ip[4]; unsigned char ip[4];
unsigned short port; unsigned short port;
char *str,*e; char *str=NULL,*e;
const char *h,*p; const char *h,*p;
unsigned long l; unsigned long l;
int err_num; int err_num;
@ -553,7 +553,7 @@ int BIO_get_accept_socket(char *host, int bind_mode)
h="*"; h="*";
} }
if (!BIO_get_port(p,&port)) return(INVALID_SOCKET); if (!BIO_get_port(p,&port)) goto err;
memset((char *)&server,0,sizeof(server)); memset((char *)&server,0,sizeof(server));
server.sin_family=AF_INET; server.sin_family=AF_INET;
@ -563,7 +563,7 @@ int BIO_get_accept_socket(char *host, int bind_mode)
server.sin_addr.s_addr=INADDR_ANY; server.sin_addr.s_addr=INADDR_ANY;
else else
{ {
if (!BIO_get_host_ip(h,&(ip[0]))) return(INVALID_SOCKET); if (!BIO_get_host_ip(h,&(ip[0]))) goto err;
l=(unsigned long) l=(unsigned long)
((unsigned long)ip[0]<<24L)| ((unsigned long)ip[0]<<24L)|
((unsigned long)ip[1]<<16L)| ((unsigned long)ip[1]<<16L)|