Enhance PACKET readability

Enhance the PACKET code readability, and fix a stale comment. Thanks
to Ben Kaduk (bkaduk@akamai.com) for pointing this out.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
This commit is contained in:
Matt Caswell
2015-08-03 17:20:47 +01:00
parent f9f6053442
commit bc6616a434
4 changed files with 5 additions and 6 deletions

View File

@@ -2036,7 +2036,7 @@ static int ssl_scan_clienthello_tlsext(SSL *s, PACKET *pkt, int *al)
}
}
/* We shouldn't have any bytes left */
if (PACKET_remaining(&ssubpkt))
if (PACKET_remaining(&ssubpkt) != 0)
goto err;
}
@@ -2140,7 +2140,7 @@ static int ssl_scan_clienthello_tlsext(SSL *s, PACKET *pkt, int *al)
|| (dsize & 1) != 0
|| (dsize == 0)
|| !PACKET_get_bytes(&subpkt, &data, dsize)
|| PACKET_remaining(&subpkt)
|| PACKET_remaining(&subpkt) != 0
|| !tls1_save_sigalgs(s, data, dsize)) {
goto err;
}