Tolerate fragmentation and interleaving in the SSL 3/TLS record layer.
This commit is contained in:
parent
9f7b1b24e2
commit
b35e9050f2
4
CHANGES
4
CHANGES
@ -4,6 +4,10 @@
|
||||
|
||||
Changes between 0.9.4 and 0.9.5 [xx XXX 2000]
|
||||
|
||||
*) Bugfix: Tolerate fragmentation and interleaving in the SSL 3/TLS
|
||||
record layer.
|
||||
[Bodo Moeller]
|
||||
|
||||
*) Change the 'other' type in certificate aux info to a STACK_OF
|
||||
X509_ALGOR. Although not an AlgorithmIdentifier as such it has
|
||||
the required ASN1 format: arbitrary types determined by an OID.
|
||||
|
@ -200,6 +200,7 @@ int ssl23_get_client_hello(SSL *s)
|
||||
* 6-8 length > Client Hello message
|
||||
* 9/10 client_version /
|
||||
*/
|
||||
/* XXX */
|
||||
char *buf= &(buf_space[0]);
|
||||
unsigned char *p,*d,*dd;
|
||||
unsigned int i;
|
||||
@ -277,6 +278,7 @@ int ssl23_get_client_hello(SSL *s)
|
||||
* throw this away and implement it in a way
|
||||
* that makes sense */
|
||||
{
|
||||
#if 0
|
||||
STACK_OF(SSL_CIPHER) *sk;
|
||||
SSL_CIPHER *c;
|
||||
int ne2,ne3;
|
||||
@ -326,6 +328,10 @@ int ssl23_get_client_hello(SSL *s)
|
||||
goto next_bit;
|
||||
}
|
||||
}
|
||||
#else
|
||||
SSLerr(SSL_F_SSL23_GET_CLIENT_HELLO,SSL_R_UNSUPPORTED_OPTION);
|
||||
goto err;
|
||||
#endif
|
||||
}
|
||||
}
|
||||
}
|
||||
|
18
ssl/s2_lib.c
18
ssl/s2_lib.c
@ -262,14 +262,14 @@ int ssl2_pending(SSL *s)
|
||||
|
||||
int ssl2_new(SSL *s)
|
||||
{
|
||||
SSL2_CTX *s2;
|
||||
SSL2_STATE *s2;
|
||||
|
||||
if ((s2=(SSL2_CTX *)Malloc(sizeof(SSL2_CTX))) == NULL) goto err;
|
||||
memset(s2,0,sizeof(SSL2_CTX));
|
||||
if ((s2=Malloc(sizeof *s2)) == NULL) goto err;
|
||||
memset(s2,0,sizeof *s2);
|
||||
|
||||
if ((s2->rbuf=(unsigned char *)Malloc(
|
||||
if ((s2->rbuf=Malloc(
|
||||
SSL2_MAX_RECORD_LENGTH_2_BYTE_HEADER+2)) == NULL) goto err;
|
||||
if ((s2->wbuf=(unsigned char *)Malloc(
|
||||
if ((s2->wbuf=Malloc(
|
||||
SSL2_MAX_RECORD_LENGTH_2_BYTE_HEADER+2)) == NULL) goto err;
|
||||
s->s2=s2;
|
||||
|
||||
@ -287,7 +287,7 @@ err:
|
||||
|
||||
void ssl2_free(SSL *s)
|
||||
{
|
||||
SSL2_CTX *s2;
|
||||
SSL2_STATE *s2;
|
||||
|
||||
if(s == NULL)
|
||||
return;
|
||||
@ -295,14 +295,14 @@ void ssl2_free(SSL *s)
|
||||
s2=s->s2;
|
||||
if (s2->rbuf != NULL) Free(s2->rbuf);
|
||||
if (s2->wbuf != NULL) Free(s2->wbuf);
|
||||
memset(s2,0,sizeof(SSL2_CTX));
|
||||
memset(s2,0,sizeof *s2);
|
||||
Free(s2);
|
||||
s->s2=NULL;
|
||||
}
|
||||
|
||||
void ssl2_clear(SSL *s)
|
||||
{
|
||||
SSL2_CTX *s2;
|
||||
SSL2_STATE *s2;
|
||||
unsigned char *rbuf,*wbuf;
|
||||
|
||||
s2=s->s2;
|
||||
@ -310,7 +310,7 @@ void ssl2_clear(SSL *s)
|
||||
rbuf=s2->rbuf;
|
||||
wbuf=s2->wbuf;
|
||||
|
||||
memset(s2,0,sizeof(SSL2_CTX));
|
||||
memset(s2,0,sizeof *s2);
|
||||
|
||||
s2->rbuf=rbuf;
|
||||
s2->wbuf=wbuf;
|
||||
|
@ -898,7 +898,7 @@ static int request_certificate(SSL *s)
|
||||
EVP_VerifyUpdate(&ctx,ccd,SSL2_MIN_CERT_CHALLENGE_LENGTH);
|
||||
|
||||
i=i2d_X509(s->cert->pkeys[SSL_PKEY_RSA_ENC].x509,NULL);
|
||||
buf2=(unsigned char *)Malloc((unsigned int)i);
|
||||
buf2=Malloc((unsigned int)i);
|
||||
if (buf2 == NULL)
|
||||
{
|
||||
SSLerr(SSL_F_REQUEST_CERTIFICATE,ERR_R_MALLOC_FAILURE);
|
||||
|
@ -123,7 +123,7 @@ int ssl3_get_finished(SSL *s, int a, int b)
|
||||
|
||||
if (!ok) return((int)n);
|
||||
|
||||
/* If this occurs if we has missed a message */
|
||||
/* If this occurs, we have missed a message */
|
||||
if (!s->s3->change_cipher_spec)
|
||||
{
|
||||
al=SSL_AD_UNEXPECTED_MESSAGE;
|
||||
@ -283,16 +283,22 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, long max, int *ok)
|
||||
|
||||
p=(unsigned char *)s->init_buf->data;
|
||||
|
||||
if (s->state == st1)
|
||||
if (s->state == st1) /* s->init_num < 4 */
|
||||
{
|
||||
while (s->init_num < 4)
|
||||
{
|
||||
i=ssl3_read_bytes(s,SSL3_RT_HANDSHAKE,&p[s->init_num],
|
||||
4-s->init_num);
|
||||
if (i < (4-s->init_num))
|
||||
if (i <= 0)
|
||||
{
|
||||
*ok=0;
|
||||
return(ssl3_part_read(s,i));
|
||||
s->rwstate=SSL_READING;
|
||||
*ok = 0;
|
||||
return i;
|
||||
}
|
||||
s->init_num+=i;
|
||||
}
|
||||
|
||||
/* XXX server may always send Hello Request */
|
||||
if ((mt >= 0) && (*p != mt))
|
||||
{
|
||||
al=SSL_AD_UNEXPECTED_MESSAGE;
|
||||
@ -334,17 +340,20 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, long max, int *ok)
|
||||
/* next state (stn) */
|
||||
p=(unsigned char *)s->init_buf->data;
|
||||
n=s->s3->tmp.message_size;
|
||||
if (n > 0)
|
||||
while (n > 0)
|
||||
{
|
||||
i=ssl3_read_bytes(s,SSL3_RT_HANDSHAKE,&p[s->init_num],n);
|
||||
if (i != (int)n)
|
||||
if (i <= 0)
|
||||
{
|
||||
*ok=0;
|
||||
return(ssl3_part_read(s,i));
|
||||
s->rwstate=SSL_READING;
|
||||
*ok = 0;
|
||||
return i;
|
||||
}
|
||||
s->init_num += i;
|
||||
n -= i;
|
||||
}
|
||||
*ok=1;
|
||||
return(n);
|
||||
return s->init_num;
|
||||
f_err:
|
||||
ssl3_send_alert(s,SSL3_AL_FATAL,al);
|
||||
err:
|
||||
@ -465,7 +474,7 @@ int ssl3_setup_buffers(SSL *s)
|
||||
extra=SSL3_RT_MAX_EXTRA;
|
||||
else
|
||||
extra=0;
|
||||
if ((p=(unsigned char *)Malloc(SSL3_RT_MAX_PACKET_SIZE+extra))
|
||||
if ((p=Malloc(SSL3_RT_MAX_PACKET_SIZE+extra))
|
||||
== NULL)
|
||||
goto err;
|
||||
s->s3->rbuf.buf=p;
|
||||
@ -473,7 +482,7 @@ int ssl3_setup_buffers(SSL *s)
|
||||
|
||||
if (s->s3->wbuf.buf == NULL)
|
||||
{
|
||||
if ((p=(unsigned char *)Malloc(SSL3_RT_MAX_PACKET_SIZE))
|
||||
if ((p=Malloc(SSL3_RT_MAX_PACKET_SIZE))
|
||||
== NULL)
|
||||
goto err;
|
||||
s->s3->wbuf.buf=p;
|
||||
|
@ -300,7 +300,7 @@ int ssl3_setup_key_block(SSL *s)
|
||||
|
||||
ssl3_cleanup_key_block(s);
|
||||
|
||||
if ((p=(unsigned char *)Malloc(num)) == NULL)
|
||||
if ((p=Malloc(num)) == NULL)
|
||||
goto err;
|
||||
|
||||
s->s3->tmp.key_block_length=num;
|
||||
|
40
ssl/s3_lib.c
40
ssl/s3_lib.c
@ -655,19 +655,12 @@ int ssl3_pending(SSL *s)
|
||||
|
||||
int ssl3_new(SSL *s)
|
||||
{
|
||||
SSL3_CTX *s3;
|
||||
SSL3_STATE *s3;
|
||||
|
||||
if ((s3=(SSL3_CTX *)Malloc(sizeof(SSL3_CTX))) == NULL) goto err;
|
||||
memset(s3,0,sizeof(SSL3_CTX));
|
||||
if ((s3=Malloc(sizeof *s3)) == NULL) goto err;
|
||||
memset(s3,0,sizeof *s3);
|
||||
|
||||
s->s3=s3;
|
||||
/*
|
||||
s->s3->tmp.ca_names=NULL;
|
||||
s->s3->tmp.key_block=NULL;
|
||||
s->s3->tmp.key_block_length=0;
|
||||
s->s3->rbuf.buf=NULL;
|
||||
s->s3->wbuf.buf=NULL;
|
||||
*/
|
||||
|
||||
s->method->ssl_clear(s);
|
||||
return(1);
|
||||
@ -693,7 +686,7 @@ void ssl3_free(SSL *s)
|
||||
#endif
|
||||
if (s->s3->tmp.ca_names != NULL)
|
||||
sk_X509_NAME_pop_free(s->s3->tmp.ca_names,X509_NAME_free);
|
||||
memset(s->s3,0,sizeof(SSL3_CTX));
|
||||
memset(s->s3,0,sizeof *s->s3);
|
||||
Free(s->s3);
|
||||
s->s3=NULL;
|
||||
}
|
||||
@ -715,7 +708,7 @@ void ssl3_clear(SSL *s)
|
||||
rp=s->s3->rbuf.buf;
|
||||
wp=s->s3->wbuf.buf;
|
||||
|
||||
memset(s->s3,0,sizeof(SSL3_CTX));
|
||||
memset(s->s3,0,sizeof *s->s3);
|
||||
if (rp != NULL) s->s3->rbuf.buf=rp;
|
||||
if (wp != NULL) s->s3->wbuf.buf=wp;
|
||||
|
||||
@ -999,21 +992,6 @@ int ssl3_put_cipher_by_char(const SSL_CIPHER *c, unsigned char *p)
|
||||
return(2);
|
||||
}
|
||||
|
||||
int ssl3_part_read(SSL *s, int i)
|
||||
{
|
||||
s->rwstate=SSL_READING;
|
||||
|
||||
if (i < 0)
|
||||
{
|
||||
return(i);
|
||||
}
|
||||
else
|
||||
{
|
||||
s->init_num+=i;
|
||||
return(0);
|
||||
}
|
||||
}
|
||||
|
||||
SSL_CIPHER *ssl3_choose_cipher(SSL *s, STACK_OF(SSL_CIPHER) *have,
|
||||
STACK_OF(SSL_CIPHER) *pref)
|
||||
{
|
||||
@ -1214,8 +1192,12 @@ int ssl3_read(SSL *s, void *buf, int len)
|
||||
ret=ssl3_read_bytes(s,SSL3_RT_APPLICATION_DATA,buf,len);
|
||||
if ((ret == -1) && (s->s3->in_read_app_data == 0))
|
||||
{
|
||||
ERR_get_error(); /* clear the error */
|
||||
s->s3->in_read_app_data=0;
|
||||
/* ssl3_read_bytes decided to call s->handshake_func, which
|
||||
* called ssl3_read_bytes to read handshake data.
|
||||
* However, ssl3_read_bytes actually found application data
|
||||
* and thinks that application data makes sense here (signalled
|
||||
* by resetting 'in_read_app_data', strangely); so disable
|
||||
* handshake processing and try to read application data again. */
|
||||
s->in_handshake++;
|
||||
ret=ssl3_read_bytes(s,SSL3_RT_APPLICATION_DATA,buf,len);
|
||||
s->in_handshake--;
|
||||
|
253
ssl/s3_pkt.c
253
ssl/s3_pkt.c
@ -125,6 +125,7 @@ static int do_compress(SSL *ssl);
|
||||
static int do_uncompress(SSL *ssl);
|
||||
static int do_change_cipher_spec(SSL *ssl);
|
||||
|
||||
/* used only by ssl3_get_record */
|
||||
static int ssl3_read_n(SSL *s, int n, int max, int extend)
|
||||
{
|
||||
/* If extend == 0, obtain new n-byte packet; if extend == 1, increase
|
||||
@ -226,11 +227,11 @@ static int ssl3_read_n(SSL *s, int n, int max, int extend)
|
||||
* ssl->s3->rrec.data, - data
|
||||
* ssl->s3->rrec.length, - number of bytes
|
||||
*/
|
||||
/* used only by ssl3_read_bytes */
|
||||
static int ssl3_get_record(SSL *s)
|
||||
{
|
||||
int ssl_major,ssl_minor,al;
|
||||
int n,i,ret= -1;
|
||||
SSL3_BUFFER *rb;
|
||||
SSL3_RECORD *rr;
|
||||
SSL_SESSION *sess;
|
||||
unsigned char *p;
|
||||
@ -240,7 +241,6 @@ static int ssl3_get_record(SSL *s)
|
||||
int clear=0,extra;
|
||||
|
||||
rr= &(s->s3->rrec);
|
||||
rb= &(s->s3->rbuf);
|
||||
sess=s->session;
|
||||
|
||||
if (s->options & SSL_OP_MICROSOFT_BIG_SSLV3_BUFFER)
|
||||
@ -680,6 +680,33 @@ static int ssl3_write_pending(SSL *s, int type, const unsigned char *buf,
|
||||
}
|
||||
}
|
||||
|
||||
/* Return up to 'len' payload bytes received in 'type' records.
|
||||
* 'type' is one of the following:
|
||||
*
|
||||
* - SSL3_RT_HANDSHAKE (when ssl3_get_message calls us)
|
||||
* - SSL3_RT_APPLICATION_DATA (when ssl3_read calls us)
|
||||
* - 0 (during a shutdown, no data has to be returned)
|
||||
*
|
||||
* If we don't have stored data to work from, read a SSL/TLS record first
|
||||
* (possibly multiple records if we still don't have anything to return).
|
||||
*
|
||||
* This function must handle any surprises the peer may have for us, such as
|
||||
* Alert records (e.g. close_notify), ChangeCipherSpec records (not really
|
||||
* a surprise, but handled as if it were), or renegotiation requests.
|
||||
* Also if record payloads contain fragments too small to process, we store
|
||||
* them until there is enough for the respective protocol (the record protocol
|
||||
* may use arbitrary fragmentation and even interleaving):
|
||||
* Change cipher spec protocol
|
||||
* just 1 byte needed, no need for keeping anything stored
|
||||
* Alert protocol
|
||||
* 2 bytes needed (AlertLevel, AlertDescription)
|
||||
* Handshake protocol
|
||||
* 4 bytes needed (HandshakeType, uint24 length) -- we just have
|
||||
* to detect unexpected Client Hello and Hello Request messages
|
||||
* here, anything else is handled by higher layers
|
||||
* Application data protocol
|
||||
* none of our business
|
||||
*/
|
||||
int ssl3_read_bytes(SSL *s, int type, unsigned char *buf, int len)
|
||||
{
|
||||
int al,i,j,n,ret;
|
||||
@ -691,8 +718,37 @@ int ssl3_read_bytes(SSL *s, int type, unsigned char *buf, int len)
|
||||
if (!ssl3_setup_buffers(s))
|
||||
return(-1);
|
||||
|
||||
if ((type != SSL3_RT_APPLICATION_DATA) && (type != SSL3_RT_HANDSHAKE) && type)
|
||||
{
|
||||
SSLerr(SSL_F_SSL3_READ_BYTES, SSL_R_INTERNAL_ERROR);
|
||||
return -1;
|
||||
}
|
||||
|
||||
if ((type == SSL3_RT_HANDSHAKE) && (s->s3->handshake_fragment_len > 0))
|
||||
/* (partially) satisfy request from storage */
|
||||
{
|
||||
unsigned char *src = s->s3->handshake_fragment;
|
||||
unsigned char *dst = buf;
|
||||
|
||||
n = 0;
|
||||
while ((len > 0) && (s->s3->handshake_fragment_len > 0))
|
||||
{
|
||||
*dst++ = *src++;
|
||||
len--; s->s3->handshake_fragment_len--;
|
||||
n++;
|
||||
}
|
||||
/* move any remaining fragment bytes: */
|
||||
for (i = 0; i < s->s3->handshake_fragment_len; i++)
|
||||
s->s3->handshake_fragment[i] = *src++;
|
||||
ssl3_finish_mac(s, buf, n);
|
||||
return n;
|
||||
}
|
||||
|
||||
/* Now s->s3->handshake_fragment_len == 0 if type == SSL3_RT_HANDSHAKE. */
|
||||
|
||||
if (!s->in_handshake && SSL_in_init(s))
|
||||
{
|
||||
/* type == SSL3_RT_APPLICATION_DATA */
|
||||
i=s->handshake_func(s);
|
||||
if (i < 0) return(i);
|
||||
if (i == 0)
|
||||
@ -708,7 +764,7 @@ start:
|
||||
* s->s3->rrec.data, - data
|
||||
* s->s3->rrec.off, - offset into 'data' for next read
|
||||
* s->s3->rrec.length, - number of bytes. */
|
||||
rr= &(s->s3->rrec);
|
||||
rr = &(s->s3->rrec);
|
||||
|
||||
/* get new packet */
|
||||
if ((rr->length == 0) || (s->rstate == SSL_ST_READ_BODY))
|
||||
@ -719,7 +775,9 @@ start:
|
||||
|
||||
/* we now have a packet which can be read and processed */
|
||||
|
||||
if (s->s3->change_cipher_spec && (rr->type != SSL3_RT_HANDSHAKE))
|
||||
if (s->s3->change_cipher_spec /* set when we receive ChangeCipherSpec,
|
||||
* reset by ssl3_get_finished */
|
||||
&& (rr->type != SSL3_RT_HANDSHAKE))
|
||||
{
|
||||
al=SSL_AD_UNEXPECTED_MESSAGE;
|
||||
SSLerr(SSL_F_SSL3_READ_BYTES,SSL_R_DATA_BETWEEN_CCS_AND_FINISHED);
|
||||
@ -734,13 +792,98 @@ start:
|
||||
return(0);
|
||||
}
|
||||
|
||||
/* Check for an incoming 'Hello Request' message from client */
|
||||
if ((rr->type == SSL3_RT_HANDSHAKE) && (rr->length == 4) &&
|
||||
(rr->data[0] == SSL3_MT_HELLO_REQUEST) &&
|
||||
|
||||
if (type == rr->type) /* SSL3_RT_APPLICATION_DATA or SSL3_RT_HANDSHAKE */
|
||||
{
|
||||
/* make sure that we are not getting application data when we
|
||||
* are doing a handshake for the first time */
|
||||
if (SSL_in_init(s) && (type == SSL3_RT_APPLICATION_DATA) &&
|
||||
(s->enc_read_ctx == NULL))
|
||||
{
|
||||
al=SSL_AD_UNEXPECTED_MESSAGE;
|
||||
SSLerr(SSL_F_SSL3_READ_BYTES,SSL_R_APP_DATA_IN_HANDSHAKE);
|
||||
goto f_err;
|
||||
}
|
||||
|
||||
if (len <= 0) return(len);
|
||||
|
||||
if ((unsigned int)len > rr->length)
|
||||
n=rr->length;
|
||||
else
|
||||
n=len;
|
||||
|
||||
memcpy(buf,&(rr->data[rr->off]),(unsigned int)n);
|
||||
rr->length-=n;
|
||||
rr->off+=n;
|
||||
if (rr->length == 0)
|
||||
{
|
||||
s->rstate=SSL_ST_READ_HEADER;
|
||||
rr->off=0;
|
||||
}
|
||||
|
||||
if (type == SSL3_RT_HANDSHAKE)
|
||||
ssl3_finish_mac(s,buf,n);
|
||||
return(n);
|
||||
}
|
||||
|
||||
|
||||
/* If we get here, then type != rr->type; if we have a handshake
|
||||
* message, then it was unexpected (Hello Request or Client Hello). */
|
||||
|
||||
/* In case of record types for which we have 'fragment' storage,
|
||||
* fill that so that we can process the data at a fixed place.
|
||||
*/
|
||||
{
|
||||
int dest_maxlen = 0;
|
||||
unsigned char *dest;
|
||||
int *dest_len;
|
||||
|
||||
if (rr->type == SSL3_RT_HANDSHAKE)
|
||||
{
|
||||
dest_maxlen = sizeof s->s3->handshake_fragment;
|
||||
dest = s->s3->handshake_fragment;
|
||||
dest_len = &s->s3->handshake_fragment_len;
|
||||
}
|
||||
else if (rr->type == SSL3_RT_ALERT)
|
||||
{
|
||||
dest_maxlen = sizeof s->s3->alert_fragment;
|
||||
dest = s->s3->alert_fragment;
|
||||
dest_len = &s->s3->alert_fragment_len;
|
||||
}
|
||||
|
||||
if (dest_maxlen > 0)
|
||||
{
|
||||
n = dest_maxlen - *dest_len; /* available space in 'dest' */
|
||||
if (rr->length < n)
|
||||
n = rr->length; /* available bytes */
|
||||
|
||||
/* now move 'n' bytes: */
|
||||
while (n-- > 0)
|
||||
{
|
||||
dest[(*dest_len)++] = rr->data[rr->off++];
|
||||
rr->length--;
|
||||
}
|
||||
|
||||
if (*dest_len < dest_maxlen)
|
||||
goto start; /* fragment was too small */
|
||||
}
|
||||
}
|
||||
|
||||
/* s->s3->handshake_fragment_len == 4 iff rr->type == SSL3_RT_HANDSHAKE;
|
||||
* s->s3->alert_fragment_len == 2 iff rr->type == SSL3_RT_ALERT.
|
||||
* (Possibly rr is 'empty' now, i.e. rr->length may be 0.) */
|
||||
|
||||
/* If we are a client, check for an incoming 'Hello Request': */
|
||||
if ((!s->server) &&
|
||||
(s->s3->handshake_fragment_len >= 4) &&
|
||||
(s->s3->handshake_fragment[0] == SSL3_MT_HELLO_REQUEST) &&
|
||||
(s->session != NULL) && (s->session->cipher != NULL))
|
||||
{
|
||||
if ((rr->data[1] != 0) || (rr->data[2] != 0) ||
|
||||
(rr->data[3] != 0))
|
||||
s->s3->handshake_fragment_len = 0;
|
||||
|
||||
if ((s->s3->handshake_fragment[1] != 0) ||
|
||||
(s->s3->handshake_fragment[2] != 0) ||
|
||||
(s->s3->handshake_fragment[3] != 0))
|
||||
{
|
||||
al=SSL_AD_DECODE_ERROR;
|
||||
SSLerr(SSL_F_SSL3_READ_BYTES,SSL_R_BAD_HELLO_REQUEST);
|
||||
@ -763,28 +906,17 @@ start:
|
||||
}
|
||||
}
|
||||
}
|
||||
rr->length=0;
|
||||
/* ZZZ */ goto start;
|
||||
/* we either finished a handshake or ignored the request,
|
||||
* now try again to obtain the (application) data we were asked for */
|
||||
goto start;
|
||||
}
|
||||
|
||||
/* if it is not the type we want, or we have shutdown and want
|
||||
* the peer shutdown */
|
||||
if ((rr->type != type) || (s->shutdown & SSL_SENT_SHUTDOWN))
|
||||
if (s->s3->alert_fragment_len >= 2)
|
||||
{
|
||||
if (rr->type == SSL3_RT_ALERT)
|
||||
{
|
||||
if ((rr->length != 2) || (rr->off != 0))
|
||||
{
|
||||
al=SSL_AD_DECODE_ERROR;
|
||||
SSLerr(SSL_F_SSL3_READ_BYTES,SSL_R_BAD_ALERT_RECORD);
|
||||
goto f_err;
|
||||
}
|
||||
i = s->s3->alert_fragment[0];
|
||||
n = s->s3->alert_fragment[1];
|
||||
|
||||
i=rr->data[0];
|
||||
n=rr->data[1];
|
||||
|
||||
/* clear from buffer */
|
||||
rr->length=0;
|
||||
s->s3->alert_fragment_len = 0;
|
||||
|
||||
if (s->info_callback != NULL)
|
||||
cb=s->info_callback;
|
||||
@ -827,11 +959,10 @@ start:
|
||||
goto f_err;
|
||||
}
|
||||
|
||||
rr->length=0;
|
||||
goto start;
|
||||
}
|
||||
|
||||
if (s->shutdown & SSL_SENT_SHUTDOWN)
|
||||
if (s->shutdown & SSL_SENT_SHUTDOWN) /* but we have not received a shutdown */
|
||||
{
|
||||
s->rwstate=SSL_NOTHING;
|
||||
rr->length=0;
|
||||
@ -840,6 +971,8 @@ start:
|
||||
|
||||
if (rr->type == SSL3_RT_CHANGE_CIPHER_SPEC)
|
||||
{
|
||||
/* 'Change Cipher Spec' is just a single byte, so we know
|
||||
* exactly what the record payload has to look like */
|
||||
if ( (rr->length != 1) || (rr->off != 0) ||
|
||||
(rr->data[0] != SSL3_MT_CCS))
|
||||
{
|
||||
@ -856,9 +989,8 @@ start:
|
||||
goto start;
|
||||
}
|
||||
|
||||
/* else we have a handshake */
|
||||
if ((rr->type == SSL3_RT_HANDSHAKE) &&
|
||||
!s->in_handshake)
|
||||
/* Unexpected handshake message (Client Hello, or protocol violation) */
|
||||
if ((s->s3->handshake_fragment_len >= 4) && !s->in_handshake)
|
||||
{
|
||||
if (((s->state&SSL_ST_MASK) == SSL_ST_OK) &&
|
||||
!(s->s3->flags & SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS))
|
||||
@ -899,20 +1031,25 @@ start:
|
||||
goto start;
|
||||
}
|
||||
#endif
|
||||
case SSL3_RT_CHANGE_CIPHER_SPEC:
|
||||
case SSL3_RT_ALERT:
|
||||
case SSL3_RT_HANDSHAKE:
|
||||
al=SSL_AD_UNEXPECTED_MESSAGE;
|
||||
SSLerr(SSL_F_SSL3_READ_BYTES,SSL_R_UNEXPECTED_RECORD);
|
||||
goto f_err;
|
||||
case SSL3_RT_CHANGE_CIPHER_SPEC:
|
||||
case SSL3_RT_ALERT:
|
||||
case SSL3_RT_HANDSHAKE:
|
||||
/* we already handled all of these, with the possible exception
|
||||
* of SSL3_RT_HANDSHAKE when s->in_handshake is set, but that
|
||||
* should not happen when type != rr->type */
|
||||
al=SSL_AD_UNEXPECTED_MESSAGE;
|
||||
SSLerr(SSL_F_SSL3_READ_BYTES,SSL_R_INTERNAL_ERROR);
|
||||
goto f_err;
|
||||
case SSL3_RT_APPLICATION_DATA:
|
||||
/* At this point, we were expecting something else,
|
||||
* but have application data. What we do is set the
|
||||
* error, and return -1. On the way out, if the
|
||||
* library was running inside ssl3_read() and it makes
|
||||
* sense to read application data at this point, we
|
||||
* will indulge it. This will mostly happen during
|
||||
* session renegotiation.
|
||||
/* At this point, we were expecting handshake data,
|
||||
* but have application data. If the library was
|
||||
* running inside ssl3_read() (i.e. in_read_app_data
|
||||
* is set) and it makes sense to read application data
|
||||
* at this point (session renegotation not yet started),
|
||||
* we will indulge it.
|
||||
*/
|
||||
if (s->s3->in_read_app_data &&
|
||||
(s->s3->total_renegotiations != 0) &&
|
||||
@ -938,39 +1075,7 @@ start:
|
||||
}
|
||||
}
|
||||
/* not reached */
|
||||
}
|
||||
|
||||
/* rr->type == type */
|
||||
|
||||
/* make sure that we are not getting application data when we
|
||||
* are doing a handshake for the first time */
|
||||
if (SSL_in_init(s) && (type == SSL3_RT_APPLICATION_DATA) &&
|
||||
(s->enc_read_ctx == NULL))
|
||||
{
|
||||
al=SSL_AD_UNEXPECTED_MESSAGE;
|
||||
SSLerr(SSL_F_SSL3_READ_BYTES,SSL_R_APP_DATA_IN_HANDSHAKE);
|
||||
goto f_err;
|
||||
}
|
||||
|
||||
if (len <= 0) return(len);
|
||||
|
||||
if ((unsigned int)len > rr->length)
|
||||
n=rr->length;
|
||||
else
|
||||
n=len;
|
||||
|
||||
memcpy(buf,&(rr->data[rr->off]),(unsigned int)n);
|
||||
rr->length-=n;
|
||||
rr->off+=n;
|
||||
if (rr->length == 0)
|
||||
{
|
||||
s->rstate=SSL_ST_READ_HEADER;
|
||||
rr->off=0;
|
||||
}
|
||||
|
||||
if (type == SSL3_RT_HANDSHAKE)
|
||||
ssl3_finish_mac(s,buf,n);
|
||||
return(n);
|
||||
f_err:
|
||||
ssl3_send_alert(s,SSL3_AL_FATAL,al);
|
||||
err:
|
||||
|
@ -581,8 +581,8 @@ struct ssl_st
|
||||
unsigned char *packet;
|
||||
unsigned int packet_length;
|
||||
|
||||
struct ssl2_ctx_st *s2; /* SSLv2 variables */
|
||||
struct ssl3_ctx_st *s3; /* SSLv3 variables */
|
||||
struct ssl2_state_st *s2; /* SSLv2 variables */
|
||||
struct ssl3_state_st *s3; /* SSLv3 variables */
|
||||
|
||||
int read_ahead; /* Read as many input bytes as possible
|
||||
* (for non-blocking reads) */
|
||||
@ -1510,6 +1510,7 @@ int SSL_COMP_add_compression_method(int id,char *cm);
|
||||
#define SSL_R_UNKNOWN_STATE 255
|
||||
#define SSL_R_UNSUPPORTED_CIPHER 256
|
||||
#define SSL_R_UNSUPPORTED_COMPRESSION_ALGORITHM 257
|
||||
#define SSL_R_UNSUPPORTED_OPTION 1091
|
||||
#define SSL_R_UNSUPPORTED_PROTOCOL 258
|
||||
#define SSL_R_UNSUPPORTED_SSL_VERSION 259
|
||||
#define SSL_R_WRITE_BIO_NOT_SET 260
|
||||
|
@ -151,7 +151,7 @@ extern "C" {
|
||||
#define CERT char
|
||||
#endif
|
||||
|
||||
typedef struct ssl2_ctx_st
|
||||
typedef struct ssl2_state_st
|
||||
{
|
||||
int three_byte_header;
|
||||
int clear_text; /* clear text */
|
||||
@ -214,7 +214,7 @@ typedef struct ssl2_ctx_st
|
||||
unsigned int clen;
|
||||
unsigned int rlen;
|
||||
} tmp;
|
||||
} SSL2_CTX;
|
||||
} SSL2_STATE;
|
||||
|
||||
/* SSLv2 */
|
||||
/* client */
|
||||
|
41
ssl/ssl3.h
41
ssl/ssl3.h
@ -218,34 +218,7 @@ typedef struct ssl3_buffer_st
|
||||
#define SSL3_FLAGS_POP_BUFFER 0x0004
|
||||
#define TLS1_FLAGS_TLS_PADDING_BUG 0x0008
|
||||
|
||||
#if 0
|
||||
#define AD_CLOSE_NOTIFY 0
|
||||
#define AD_UNEXPECTED_MESSAGE 1
|
||||
#define AD_BAD_RECORD_MAC 2
|
||||
#define AD_DECRYPTION_FAILED 3
|
||||
#define AD_RECORD_OVERFLOW 4
|
||||
#define AD_DECOMPRESSION_FAILURE 5 /* fatal */
|
||||
#define AD_HANDSHAKE_FAILURE 6 /* fatal */
|
||||
#define AD_NO_CERTIFICATE 7 /* Not under TLS */
|
||||
#define AD_BAD_CERTIFICATE 8
|
||||
#define AD_UNSUPPORTED_CERTIFICATE 9
|
||||
#define AD_CERTIFICATE_REVOKED 10
|
||||
#define AD_CERTIFICATE_EXPIRED 11
|
||||
#define AD_CERTIFICATE_UNKNOWN 12
|
||||
#define AD_ILLEGAL_PARAMETER 13 /* fatal */
|
||||
#define AD_UNKNOWN_CA 14 /* fatal */
|
||||
#define AD_ACCESS_DENIED 15 /* fatal */
|
||||
#define AD_DECODE_ERROR 16 /* fatal */
|
||||
#define AD_DECRYPT_ERROR 17
|
||||
#define AD_EXPORT_RESTRICION 18 /* fatal */
|
||||
#define AD_PROTOCOL_VERSION 19 /* fatal */
|
||||
#define AD_INSUFFICIENT_SECURITY 20 /* fatal */
|
||||
#define AD_INTERNAL_ERROR 21 /* fatal */
|
||||
#define AD_USER_CANCLED 22
|
||||
#define AD_NO_RENEGOTIATION 23
|
||||
#endif
|
||||
|
||||
typedef struct ssl3_ctx_st
|
||||
typedef struct ssl3_state_st
|
||||
{
|
||||
long flags;
|
||||
int delay_buf_pop_ret;
|
||||
@ -260,10 +233,16 @@ typedef struct ssl3_ctx_st
|
||||
|
||||
SSL3_BUFFER rbuf; /* read IO goes into here */
|
||||
SSL3_BUFFER wbuf; /* write IO goes into here */
|
||||
|
||||
SSL3_RECORD rrec; /* each decoded record goes in here */
|
||||
SSL3_RECORD wrec; /* goes out from here */
|
||||
/* Used by ssl3_read_n to point
|
||||
* to input data packet */
|
||||
|
||||
/* storage for Alert/Handshake protocol data received but not
|
||||
* yet processed by ssl3_read_bytes: */
|
||||
unsigned char alert_fragment[2];
|
||||
int alert_fragment_len;
|
||||
unsigned char handshake_fragment[4];
|
||||
int handshake_fragment_len;
|
||||
|
||||
/* partial write - check the numbers match */
|
||||
unsigned int wnum; /* number of bytes sent so far */
|
||||
@ -339,7 +318,7 @@ typedef struct ssl3_ctx_st
|
||||
int cert_request;
|
||||
} tmp;
|
||||
|
||||
} SSL3_CTX;
|
||||
} SSL3_STATE;
|
||||
|
||||
/* SSLv3 */
|
||||
/*client */
|
||||
|
@ -392,6 +392,7 @@ static ERR_STRING_DATA SSL_str_reasons[]=
|
||||
{SSL_R_UNKNOWN_STATE ,"unknown state"},
|
||||
{SSL_R_UNSUPPORTED_CIPHER ,"unsupported cipher"},
|
||||
{SSL_R_UNSUPPORTED_COMPRESSION_ALGORITHM ,"unsupported compression algorithm"},
|
||||
{SSL_R_UNSUPPORTED_OPTION ,"unsupported option"},
|
||||
{SSL_R_UNSUPPORTED_PROTOCOL ,"unsupported protocol"},
|
||||
{SSL_R_UNSUPPORTED_SSL_VERSION ,"unsupported ssl version"},
|
||||
{SSL_R_WRITE_BIO_NOT_SET ,"write bio not set"},
|
||||
|
@ -492,7 +492,6 @@ int ssl3_renegotiate(SSL *ssl);
|
||||
int ssl3_renegotiate_check(SSL *ssl);
|
||||
int ssl3_dispatch_alert(SSL *s);
|
||||
int ssl3_read_bytes(SSL *s, int type, unsigned char *buf, int len);
|
||||
int ssl3_part_read(SSL *s, int i);
|
||||
int ssl3_write_bytes(SSL *s, int type, const void *buf, int len);
|
||||
int ssl3_final_finish_mac(SSL *s, EVP_MD_CTX *ctx1, EVP_MD_CTX *ctx2,
|
||||
const char *sender, int slen,unsigned char *p);
|
||||
|
Loading…
x
Reference in New Issue
Block a user