generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add additional DigestInfo checks.

Browse Source 
Reencode DigestInto in DER and check against the original: this
will reject any improperly encoded DigestInfo structures.

Note: this is a precautionary measure, there is no known attack
which can exploit this.

Thanks to Brian Smith for reporting this issue.
Reviewed-by: Tim Hudson <tjh@openssl.org>
This commit is contained in:
Dr. Stephen Henson 2014-09-25 23:28:48 +01:00
parent 7b7aef9bfd
commit ad8b204386
2 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
CHANGES
View File

@ -4,7 +4,15 @@
Changes between 1.0.0n and 1.0.0o [xx XXX xxxx] Changes between 1.0.0n and 1.0.0o [xx XXX xxxx]
*) *) Add additional DigestInfo checks.
Reencode DigestInto in DER and check against the original when
verifying RSA signature: this will reject any improperly encoded
DigestInfo structures.
Note: this is a precautionary measure and no attacks are currently known.
[Steve Henson]
Changes between 1.0.0m and 1.0.0n [6 Aug 2014] Changes between 1.0.0m and 1.0.0n [6 Aug 2014]

21
crypto/rsa/rsa_sign.c
View File

@ -143,6 +143,25 @@ int RSA_sign(int type, const unsigned char *m, unsigned int m_len,
return(ret); return(ret);
} }
/*
* Check DigestInfo structure does not contain extraneous data by reencoding
* using DER and checking encoding against original.
*/
static int rsa_check_digestinfo(X509_SIG *sig, const unsigned char *dinfo, int dinfolen)
{
unsigned char *der = NULL;
int derlen;
int ret = 0;
derlen = i2d_X509_SIG(sig, &der);
if (derlen <= 0)
return 0;
if (derlen == dinfolen && !memcmp(dinfo, der, derlen))
ret = 1;
OPENSSL_cleanse(der, derlen);
OPENSSL_free(der);
return ret;
}
int int_rsa_verify(int dtype, const unsigned char *m, int int_rsa_verify(int dtype, const unsigned char *m,
unsigned int m_len, unsigned int m_len,
unsigned char *rm, size_t *prm_len, unsigned char *rm, size_t *prm_len,
@ -195,7 +214,7 @@ int int_rsa_verify(int dtype, const unsigned char *m,
if (sig == NULL) goto err; if (sig == NULL) goto err;
/* Excess data can be used to create forgeries */ /* Excess data can be used to create forgeries */
if(p != s+i) if(p != s+i || !rsa_check_digestinfo(sig, s, i))
{ {
RSAerr(RSA_F_INT_RSA_VERIFY,RSA_R_BAD_SIGNATURE); RSAerr(RSA_F_INT_RSA_VERIFY,RSA_R_BAD_SIGNATURE);
goto err; goto err;