generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

testutil: return 1 on success

Browse Source 
Require that test methods return 1 on success (not 0). This is more
customary for OpenSSL.

Reviewed-by: Rich Salz <rsalz@openssl.org>
This commit is contained in:
Emilia Kasper
2016-04-05 14:29:06 +02:00
parent 6e863f0737
commit ababe86b96
6 changed files with 25 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/ssl_test_ctx_test.c
View File

@@ -74,7 +74,7 @@ static SSL_TEST_CTX_TEST_FIXTURE set_up(const char *const test_case_name)
static int execute_test(SSL_TEST_CTX_TEST_FIXTURE fixture)
{
int ret = 1;
int success = 0;
SSL_TEST_CTX *ctx = SSL_TEST_CTX_create(conf, fixture.test_section);
@@ -87,10 +87,10 @@ static int execute_test(SSL_TEST_CTX_TEST_FIXTURE fixture)
if (!SSL_TEST_CTX_equal(ctx, fixture.expected_ctx))
goto err;
ret = 0;
success = 1;
err:
SSL_TEST_CTX_free(ctx);
return ret;
return success;
}
static int execute_failure_test(SSL_TEST_CTX_TEST_FIXTURE fixture)
@@ -101,10 +101,10 @@ static int execute_failure_test(SSL_TEST_CTX_TEST_FIXTURE fixture)
fprintf(stderr, "Parsing bad configuration %s succeeded.\n",
fixture.test_section);
SSL_TEST_CTX_free(ctx);
return 1;
return 0;
}
return 0;
return 1;
}
static void tear_down(SSL_TEST_CTX_TEST_FIXTURE fixture)