generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PR1279: Clean up CONTRIBUTING

Browse Source 
Reviewed-by: Kurt Roeckx <kurt@openssl.org>
This commit is contained in:
Rich Salz 2015-11-01 08:34:13 -05:00
parent b06935f439
commit a2aaf8be7e
1 changed files with 7 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
CONTRIBUTING
View File

@ -7,9 +7,9 @@ would like to submit a patch, send it to rt@openssl.org with
the string "[PATCH]" in the subject. Please be sure to include a the string "[PATCH]" in the subject. Please be sure to include a
textual explanation of what your patch does. textual explanation of what your patch does.
You can also make GitHub pull requests. If you do this, please also send mail to You can also make GitHub pull requests. If you do this, please also send
rt@openssl.org with a brief description and a link to the PR so that we can more mail to rt@openssl.org with a brief description and a link to the PR so
easily keep track of it. that we can more easily keep track of it.
If you are unsure as to whether a feature will be useful for the general If you are unsure as to whether a feature will be useful for the general
OpenSSL community please discuss it on the openssl-dev mailing list first. OpenSSL community please discuss it on the openssl-dev mailing list first.
@ -19,22 +19,11 @@ reason as to why that feature isn't implemented.
Patches should be as up to date as possible, preferably relative to the Patches should be as up to date as possible, preferably relative to the
current Git or the last snapshot. They should follow our coding style current Git or the last snapshot. They should follow our coding style
(see https://www.openssl.org/policies/codingstyle.html) and compile without (see https://www.openssl.org/policies/codingstyle.html) and compile without
warnings using the --strict-warnings flag. OpenSSL compiles on many warnings using the --strict-warnings flag. OpenSSL compiles on many varied
varied platforms: try to ensure you only use portable features. platforms: try to ensure you only use portable features.
Note: For legal reasons, contributions from the US can be accepted only Our preferred format for changes is "diff -u" output. One method is to use
if a TSU notification and a copy of the patch are sent to crypt@bis.doc.gov "git diff" Another is to generate it something like this:
(formerly BXA) with a copy to the ENC Encryption Request Coordinator;
please take some time to look at
http://www.bis.doc.gov/Encryption/PubAvailEncSourceCodeNofify.html [sic]
and
http://w3.access.gpo.gov/bis/ear/pdf/740.pdf (EAR Section 740.13(e))
for the details. If "your encryption source code is too large to serve as
an email attachment", they are glad to receive it by fax instead; hope you
have a cheap long-distance plan.
Our preferred format for changes is "diff -u" output. You might
generate it like this:
# cd openssl-work # cd openssl-work
# [your changes] # [your changes]