generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Check PKCS#8 pkey field is valid before cleansing.

Browse Source 
PR:3683
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 52e028b9de371da62c1e51b46592517b1068d770)
This commit is contained in:
Dr. Stephen Henson 2015-02-01 13:06:32 +00:00
parent 192e148154
commit 99ff40515d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
crypto/asn1/p8_pkey.c
View File

@ -69,7 +69,8 @@ static int pkey_cb(int operation, ASN1_VALUE **pval, const ASN1_ITEM *it,
/* Since the structure must still be valid use ASN1_OP_FREE_PRE */ /* Since the structure must still be valid use ASN1_OP_FREE_PRE */
if (operation == ASN1_OP_FREE_PRE) { if (operation == ASN1_OP_FREE_PRE) {
PKCS8_PRIV_KEY_INFO *key = (PKCS8_PRIV_KEY_INFO *)*pval; PKCS8_PRIV_KEY_INFO *key = (PKCS8_PRIV_KEY_INFO *)*pval;
if (key->pkey->value.octet_string) if (key->pkey && key->pkey->type == V_ASN1_OCTET_STRING
&& key->pkey->value.octet_string != NULL)
OPENSSL_cleanse(key->pkey->value.octet_string->data, OPENSSL_cleanse(key->pkey->value.octet_string->data,
key->pkey->value.octet_string->length); key->pkey->value.octet_string->length);
} }