generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

BN_bin2bn did *not* contain an off-by-one error;

Browse Source 
I'm still investigating what caused the segementation fault
(maybe "make clean; make" will cure it ...).
But BN_bin2bn should always reset ret->neg.
This commit is contained in:
Bodo Möller 2000-11-29 12:53:41 +00:00
parent a08bcccc67
commit 9161672950
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@ -3,9 +3,6 @@
Changes between 0.9.6 and 0.9.7 [xx XXX 2000]
*) BN_bin2bn bugfix (off-by-one error).
[Bodo Moeller]
*) Make BN_mod_inverse faster by explicitly handling small quotients
in the Euclid loop. (Speed gain about 20% for small moduli [256 or
512 bits], about 30% for larger ones [1024 or 2048 bits].)

5
crypto/bn/bn_lib.c
View File

@ -585,7 +585,6 @@ int BN_set_word(BIGNUM *a, BN_ULONG w)
return(1);
}
/* ignore negative */
BIGNUM *BN_bin2bn(const unsigned char *s, int len, BIGNUM *ret)
{
unsigned int i,m;
@ -605,7 +604,8 @@ BIGNUM *BN_bin2bn(const unsigned char *s, int len, BIGNUM *ret)
return(NULL);
i=((n-1)/BN_BYTES)+1;
m=((n-1)%(BN_BYTES));
ret->top=i-1;
ret->top=i;
ret->neg=0;
while (n-- > 0)
{
l=(l<<8L)| *(s++);
@ -776,4 +776,3 @@ int bn_cmp_words(const BN_ULONG *a, const BN_ULONG *b, int n)
}
return(0);
}