generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix bug in async_fibre_makecontext for POSIX

Browse Source 
async_fibre_makecontext was initialise the fibre first and then calling
getcontext(). It should be the other way around because the getcontext
call may overwrite some of the things we just initialised. This didn't
cause an issue on Linux and so the problem went unnoticed. On OS-X it
causes a crash.

Reviewed-by: Rich Salz <rsalz@openssl.org>
This commit is contained in:
Matt Caswell 2015-10-11 16:17:27 +01:00
parent 7fecbf6f21
commit 90fa7296c2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/async/arch/async_posix.h
View File

@ -97,8 +97,8 @@ static inline int async_fibre_swapcontext(async_fibre *o, async_fibre *n, int r)
}
# define async_fibre_makecontext(c) \
(async_fibre_init(c) \
&& !getcontext(&(c)->fibre) \
(!getcontext(&(c)->fibre) \
&& async_fibre_init(c) \
&& (makecontext(&(c)->fibre, async_start_func, 0), 1))
# define async_fibre_init_dispatcher(d)