generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Properly check return type of DH_compute_key()

Browse Source 
It returns -1 on error, not 0.

Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
MR #1231

(cherry picked from commit d6e92c0bd6)
This commit is contained in:
Pascal Cuoq
2015-05-06 09:55:28 +02:00
committed by Kurt Roeckx
parent 6481be7346
commit 738b8e6bc2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/dh/dhtest.c
View File

@@ -533,9 +533,9 @@ static int run_rfc5114_tests(void)
* Work out shared secrets using both sides and compare with expected * Work out shared secrets using both sides and compare with expected
* values. * values.
*/ */
if (!DH_compute_key(Z1, dhB->pub_key, dhA)) if (DH_compute_key(Z1, dhB->pub_key, dhA) == -1)
goto bad_err; goto bad_err;
if (!DH_compute_key(Z2, dhA->pub_key, dhB)) if (DH_compute_key(Z2, dhA->pub_key, dhB) == -1)
goto bad_err; goto bad_err;
if (memcmp(Z1, td->Z, td->Z_len)) if (memcmp(Z1, td->Z, td->Z_len))