Fix unhandled error condition in sslv2 client hello parsing.

--strict-warnings started showing warnings for this today...

Surely an error should be raised if these reads fail?

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
This commit is contained in:
Adam Eijdenberg
2015-08-04 14:59:47 -07:00
parent e77bdc7310
commit 6c3cca5793

View File

@@ -1014,6 +1014,9 @@ int ssl3_get_client_hello(SSL *s)
if (!PACKET_get_net_2(&pkt, &csl)
|| !PACKET_get_net_2(&pkt, &sil)
|| !PACKET_get_net_2(&pkt, &cl)) {
SSLerr(SSL_F_SSL3_GET_CLIENT_HELLO, SSL_R_LENGTH_TOO_SHORT);
al = SSL_AD_DECODE_ERROR;
goto f_err;
}
if (csl == 0) {