Reorder cleanup sequence in SSL_CTX_free() to leave ex_data for remove_cb().

Submitted by:
Reviewed by:
PR: 212
This commit is contained in:
Lutz Jänicke
2002-08-16 17:02:30 +00:00
parent a64f08f3dd
commit 68a9ee13e8
2 changed files with 20 additions and 3 deletions

View File

@@ -1405,13 +1405,24 @@ void SSL_CTX_free(SSL_CTX *a)
abort(); /* ok */
}
#endif
/*
* Free internal session cache. However: the remove_cb() may reference
* the ex_data of SSL_CTX, thus the ex_data store can only be removed
* after the sessions were flushed.
* As the ex_data handling routines might also touch the session cache,
* the most secure solution seems to be: empty (flush) the cache, then
* free ex_data, then finally free the cache.
* (See ticket [openssl.org #212].)
*/
if (a->sessions != NULL)
SSL_CTX_flush_sessions(a,0);
CRYPTO_free_ex_data(CRYPTO_EX_INDEX_SSL_CTX, a, &a->ex_data);
if (a->sessions != NULL)
{
SSL_CTX_flush_sessions(a,0);
lh_free(a->sessions);
}
if (a->cert_store != NULL)
X509_STORE_free(a->cert_store);
if (a->cipher_list != NULL)