Unwriteable directories are errors

Make the script and app match the documentation.

Reviewed-by: Tim Hudson <tjh@openssl.org>
This commit is contained in:
Rich Salz 2015-09-10 11:46:13 -04:00 committed by Rich Salz
parent e7451ed137
commit 4c7103a5ee
2 changed files with 4 additions and 1 deletions

View File

@ -315,7 +315,7 @@ static int do_dir(const char *dirname, enum Hash h)
if (app_access(dirname, W_OK) < 0) { if (app_access(dirname, W_OK) < 0) {
BIO_printf(bio_err, "Skipping %s, can't write\n", dirname); BIO_printf(bio_err, "Skipping %s, can't write\n", dirname);
return 0; return 1;
} }
buflen = strlen(dirname); buflen = strlen(dirname);
pathsep = (buflen && dirname[buflen - 1] == '/') ? "" : "/"; pathsep = (buflen && dirname[buflen - 1] == '/') ? "" : "/";

View File

@ -6,6 +6,7 @@
my $dir; my $dir;
my $prefix; my $prefix;
my $errorcount = 0;
my $openssl = $ENV{OPENSSL} || "openssl"; my $openssl = $ENV{OPENSSL} || "openssl";
my $pwd; my $pwd;
my $x509hash = "-subject_hash"; my $x509hash = "-subject_hash";
@ -89,9 +90,11 @@ foreach (@dirlist) {
hash_dir($_); hash_dir($_);
} else { } else {
print "Skipping $_, can't write\n"; print "Skipping $_, can't write\n";
$errorcount++;
} }
} }
} }
exit($errorcount);
sub hash_dir { sub hash_dir {
my %hashlist; my %hashlist;