free NULL cleanup -- coda
After the finale, the "real" final part. :) Do a recursive grep with "-B1 -w [a-zA-Z0-9_]*_free" to see if any of the preceeding lines are an "if NULL" check that can be removed. Reviewed-by: Tim Hudson <tjh@openssl.org>
This commit is contained in:
@@ -1202,6 +1202,9 @@ static int ssl_excert_prepend(SSL_EXCERT **pexc)
|
||||
void ssl_excert_free(SSL_EXCERT *exc)
|
||||
{
|
||||
SSL_EXCERT *curr;
|
||||
|
||||
if (!exc)
|
||||
return;
|
||||
while (exc) {
|
||||
X509_free(exc->cert);
|
||||
EVP_PKEY_free(exc->key);
|
||||
@@ -1311,8 +1314,7 @@ int args_excert(int opt, SSL_EXCERT **pexc)
|
||||
|
||||
err:
|
||||
ERR_print_errors(bio_err);
|
||||
if (exc)
|
||||
ssl_excert_free(exc);
|
||||
ssl_excert_free(exc);
|
||||
*pexc = NULL;
|
||||
return 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user