Custom extension revision.
Use the same structure for client and server custom extensions.
Add utility functions in new file t1_ext.c.
Use new utility functions to handle custom server and client extensions
and remove a lot of code duplication.
Reviewed-by: Emilia Käsper <emilia@openssl.org>
(cherry picked from commit ecf4d66090
)
Conflicts:
ssl/ssl_lib.c
ssl/ssl_locl.h
ssl/t1_lib.c
This commit is contained in:
@@ -1726,76 +1726,6 @@ void SSL_CTX_set_next_proto_select_cb(SSL_CTX *ctx, int (*cb) (SSL *s, unsigned
|
||||
}
|
||||
# endif
|
||||
|
||||
static int cert_set_custom_cli_ext(CERT *cert, unsigned short ext_type,
|
||||
custom_cli_ext_first_cb_fn fn1,
|
||||
custom_cli_ext_second_cb_fn fn2, void* arg)
|
||||
{
|
||||
size_t i;
|
||||
custom_cli_ext_record* record;
|
||||
|
||||
/* Check for duplicates */
|
||||
for (i=0; i < cert->custom_cli_ext_records_count; i++)
|
||||
if (ext_type == cert->custom_cli_ext_records[i].ext_type)
|
||||
return 0;
|
||||
|
||||
cert->custom_cli_ext_records = OPENSSL_realloc(cert->custom_cli_ext_records,
|
||||
(cert->custom_cli_ext_records_count + 1) *
|
||||
sizeof(custom_cli_ext_record));
|
||||
if (!cert->custom_cli_ext_records) {
|
||||
cert->custom_cli_ext_records_count = 0;
|
||||
return 0;
|
||||
}
|
||||
cert->custom_cli_ext_records_count++;
|
||||
record = &cert->custom_cli_ext_records[cert->custom_cli_ext_records_count - 1];
|
||||
record->ext_type = ext_type;
|
||||
record->fn1 = fn1;
|
||||
record->fn2 = fn2;
|
||||
record->arg = arg;
|
||||
return 1;
|
||||
}
|
||||
|
||||
static int cert_set_custom_srv_ext(CERT *cert, unsigned short ext_type,
|
||||
custom_srv_ext_first_cb_fn fn1,
|
||||
custom_srv_ext_second_cb_fn fn2, void* arg)
|
||||
{
|
||||
size_t i;
|
||||
custom_srv_ext_record* record;
|
||||
|
||||
/* Check for duplicates */
|
||||
for (i=0; i < cert->custom_srv_ext_records_count; i++)
|
||||
if (ext_type == cert->custom_srv_ext_records[i].ext_type)
|
||||
return 0;
|
||||
|
||||
cert->custom_srv_ext_records = OPENSSL_realloc(cert->custom_srv_ext_records,
|
||||
(cert->custom_srv_ext_records_count + 1) *
|
||||
sizeof(custom_srv_ext_record));
|
||||
if (!cert->custom_srv_ext_records) {
|
||||
cert->custom_srv_ext_records_count = 0;
|
||||
return 0;
|
||||
}
|
||||
cert->custom_srv_ext_records_count++;
|
||||
record = &cert->custom_srv_ext_records[cert->custom_srv_ext_records_count - 1];
|
||||
record->ext_type = ext_type;
|
||||
record->fn1 = fn1;
|
||||
record->fn2 = fn2;
|
||||
record->arg = arg;
|
||||
return 1;
|
||||
}
|
||||
|
||||
int SSL_CTX_set_custom_cli_ext(SSL_CTX *ctx, unsigned short ext_type,
|
||||
custom_cli_ext_first_cb_fn fn1,
|
||||
custom_cli_ext_second_cb_fn fn2, void *arg)
|
||||
{
|
||||
return cert_set_custom_cli_ext(ctx->cert, ext_type, fn1, fn2,arg);
|
||||
}
|
||||
|
||||
int SSL_CTX_set_custom_srv_ext(SSL_CTX *ctx, unsigned short ext_type,
|
||||
custom_srv_ext_first_cb_fn fn1,
|
||||
custom_srv_ext_second_cb_fn fn2, void *arg)
|
||||
{
|
||||
return cert_set_custom_srv_ext(ctx->cert, ext_type, fn1, fn2,arg);
|
||||
}
|
||||
|
||||
/* SSL_CTX_set_alpn_protos sets the ALPN protocol list on |ctx| to |protos|.
|
||||
* |protos| must be in wire-format (i.e. a series of non-empty, 8-bit
|
||||
* length-prefixed strings).
|
||||
|
Reference in New Issue
Block a user