generic-library/openssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Submitted by: Dmitry Ivanov <vonami@gmail.com>

Browse Source 
Don't leave dangling pointers in GOST engine if calls fail.
This commit is contained in:
Dr. Stephen Henson 2010-02-16 14:30:19 +00:00
parent 45d6a15ae9
commit 03fd7f27db
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engines/ccgost/gost2001.c
View File

@ -136,12 +136,14 @@ DSA_SIG *gost2001_do_sign(const unsigned char *dgst,int dlen, EC_KEY *eckey)
{ {
GOSTerr(GOST_F_GOST2001_DO_SIGN,GOST_R_RANDOM_NUMBER_GENERATOR_FAILED); GOSTerr(GOST_F_GOST2001_DO_SIGN,GOST_R_RANDOM_NUMBER_GENERATOR_FAILED);
DSA_SIG_free(newsig); DSA_SIG_free(newsig);
newsig = NULL;
goto err; goto err;
} }
if (!EC_POINT_mul(group,C,k,NULL,NULL,ctx)) if (!EC_POINT_mul(group,C,k,NULL,NULL,ctx))
{ {
GOSTerr(GOST_F_GOST2001_DO_SIGN,ERR_R_EC_LIB); GOSTerr(GOST_F_GOST2001_DO_SIGN,ERR_R_EC_LIB);
DSA_SIG_free(newsig); DSA_SIG_free(newsig);
newsig = NULL;
goto err; goto err;
} }
if (!X) X=BN_CTX_get(ctx); if (!X) X=BN_CTX_get(ctx);
@ -149,6 +151,7 @@ DSA_SIG *gost2001_do_sign(const unsigned char *dgst,int dlen, EC_KEY *eckey)
{ {
GOSTerr(GOST_F_GOST2001_DO_SIGN,ERR_R_EC_LIB); GOSTerr(GOST_F_GOST2001_DO_SIGN,ERR_R_EC_LIB);
DSA_SIG_free(newsig); DSA_SIG_free(newsig);
newsig = NULL;
goto err; goto err;
} }
if (!r) r=BN_CTX_get(ctx); if (!r) r=BN_CTX_get(ctx);