generic-library/openh264
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gmp-openh264 check buffer length before we overwrite with start code.

Browse Source
This commit is contained in:
Ethan Hugg 2015-01-14 15:28:55 -08:00
parent 9a55a8609e
commit fc6ea7e5a8
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
module/gmp-openh264.cpp
View File

@ -622,7 +622,9 @@ class OpenH264VideoDecoder : public GMPVideoDecoder {
case GMP_BufferLength32: {
uint8_t* start_code = inputFrame->Buffer();
while (start_code < inputFrame->Buffer() + inputFrame->Size()) {
// start code should be at least four bytes from the end or we risk
// reading/writing outside the buffer.
while (start_code < inputFrame->Buffer() + inputFrame->Size() - 4) {
static const uint8_t code[] = { 0x00, 0x00, 0x00, 0x01 };
uint8_t* lenp = start_code;
start_code += * (reinterpret_cast<int32_t*> (lenp));