generic-library/openh264
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

memset not required as struct is already initialized to 0.

Browse Source 
Moreover, memset causes loss of sDecParam.sVideoProperty.size
that was set previously.
This commit is contained in:
Varun B Patil 2013-12-18 11:32:40 +05:30
parent 301fd58c04
commit 2bc7d2bf86
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
codec/console/dec/src/h264dec.cpp
View File

@ -344,7 +344,6 @@ int32_t main (int32_t iArgC, char* pArgV[]) {
printf ("Specified file: %s not exist, maybe invalid path or parameter settting.\n", cReadCfg.GetFileName().c_str()); printf ("Specified file: %s not exist, maybe invalid path or parameter settting.\n", cReadCfg.GetFileName().c_str());
return 1; return 1;
} }
memset (&sDecParam, 0, sizeof (sDecParam));
while (!cReadCfg.EndOfFile()) { while (!cReadCfg.EndOfFile()) {
long nRd = cReadCfg.ReadLine (&strTag[0]); long nRd = cReadCfg.ReadLine (&strTag[0]);
@ -382,7 +381,6 @@ int32_t main (int32_t iArgC, char* pArgV[]) {
} else if (strstr (pArgV[1], } else if (strstr (pArgV[1],
".264")) { // no output dump yuv file, just try to render the decoded pictures //confirmed_safe_unsafe_usage ".264")) { // no output dump yuv file, just try to render the decoded pictures //confirmed_safe_unsafe_usage
strInputFile = pArgV[1]; strInputFile = pArgV[1];
memset (&sDecParam, 0, sizeof (sDecParam));
sDecParam.iOutputColorFormat = videoFormatI420; sDecParam.iOutputColorFormat = videoFormatI420;
sDecParam.uiTargetDqLayer = (uint8_t) - 1; sDecParam.uiTargetDqLayer = (uint8_t) - 1;
sDecParam.uiEcActiveFlag = 1; sDecParam.uiEcActiveFlag = 1;
@ -391,7 +389,6 @@ int32_t main (int32_t iArgC, char* pArgV[]) {
} else { //iArgC > 2 } else { //iArgC > 2
strInputFile = pArgV[1]; strInputFile = pArgV[1];
strOutputFile = pArgV[2]; strOutputFile = pArgV[2];
memset (&sDecParam, 0, sizeof (sDecParam));
sDecParam.iOutputColorFormat = videoFormatI420; sDecParam.iOutputColorFormat = videoFormatI420;
sDecParam.uiTargetDqLayer = (uint8_t) - 1; sDecParam.uiTargetDqLayer = (uint8_t) - 1;
sDecParam.uiEcActiveFlag = 1; sDecParam.uiEcActiveFlag = 1;