generic-library/openh264
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove an impossible condition

Browse Source 
uiIntraPeriod is unsigned, and thus can't ever be negative.

The subtraction on the line above can't ever make the value wrap
around either, since param_.uiIntraPeriod % uiGOPSize always is
smaller than or equal to param_.uiIntraPeriod. Thus, the check
never is necessary even if the value would be signed either.

This fixes warnings when building with clang.
This commit is contained in:
Martin Storsjö 2014-10-29 20:29:43 +02:00
parent a625dc836d
commit 2907cb2875
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/api/encode_decode_api_test.cpp
View File

@ -282,9 +282,6 @@ void EncodeDecodeTestAPI::ValidateParamExtCombination() {
//IntraPeriod
uiGOPSize = 1 << (param_.iTemporalLayerNum - 1);
param_.uiIntraPeriod -= param_.uiIntraPeriod % uiGOPSize;
if (param_.uiIntraPeriod < 0) {
param_.uiIntraPeriod = 0;
}
//RefNum
int32_t iRefUpperBound = (param_.iUsageType == CAMERA_VIDEO_REAL_TIME) ?