generic-library/openh264
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Validate that iLoopFilterDisableIdc is set to a sensible value in ParamValidationExt

Browse Source 
In WelsEncoderParamAdjust it is already clipped in the
same way, but here we should probably rather error out
than to silently clip it to the right range.
This commit is contained in:
Martin Storsjö 2014-11-28 13:06:41 +02:00
parent 24cd934ba9
commit 0bae0f869a
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
codec/encoder/core/src/encoder_ext.cpp
View File

@ -261,6 +261,12 @@ int32_t ParamValidationExt (SLogContext* pLogCtx, SWelsSvcCodingParam* pCodingPa
pCodingParam->uiIntraPeriod, pCodingParam->uiGopSize);
return ENC_RETURN_UNSUPPORTED_PARA;
}
if (pCodingParam->iLoopFilterDisableIdc < 0 || pCodingParam->iLoopFilterDisableIdc > 6) {
WelsLog (pLogCtx, WELS_LOG_ERROR,
"ParamValidationExt(), iLoopFilterDisableIdc(%d) must be between 0 and 6",
pCodingParam->iLoopFilterDisableIdc);
return ENC_RETURN_UNSUPPORTED_PARA;
}
//about iMultipleThreadIdc, bDeblockingParallelFlag, iLoopFilterDisableIdc, & uiSliceMode