
That commit introduces problems, as it breaks certain use cases of OpenCV functions; for example, convertTo of an Nx1 matrix to an std::vector. Since vectors can't store separate width and height values, OpenCV considers them to always be 1xN. So even though the vector is created with .create(N, 1), the Mat passed to getContinousSize has dimensions 1xN, and the size comparison fails, even though the operation itself is safe. This is a use case we probably don't want to break, at the very least for backwards compatibility. So I'm reverting the commit. This will also unfix bug #3319; I'll submit a less intrusive solution as a PR to 2.4, which will also revert 4f9c081 there.
OpenCV: Open Source Computer Vision Library
Resources
- Homepage: http://opencv.org
- Docs: http://docs.opencv.org
- Q&A forum: http://answers.opencv.org
- Issue tracking: http://code.opencv.org
Contributing
Please read before starting work on a pull request: http://code.opencv.org/projects/opencv/wiki/How_to_contribute
Summary of guidelines:
- One pull request per issue;
- Choose the right base branch;
- Include tests and documentation;
- Clean up "oops" commits before submitting;
- Follow the coding style guide.
Description
Languages
C++
83.4%
Cuda
5.9%
C
3.8%
Java
2.4%
CMake
2.2%
Other
2.1%