generic-library/opencv
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed self-assignment in cv::Ptr::operator =

Browse Source 
A self-assignment leads to a call of release() with refcount being 2. In the release() method, refcount is decremented and then successfully checked for being 1. As a consequence, the underlying data is released. To prevent this, we test for a self-assignment
This commit is contained in:
PhilLab 2014-08-08 17:39:12 +02:00
parent 3334b1437b
commit efc1c39315
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
modules/core/include/opencv2/core/operations.hpp
View File

@ -2625,12 +2625,15 @@ template<typename _Tp> inline Ptr<_Tp>::Ptr(const Ptr<_Tp>& _ptr)
template<typename _Tp> inline Ptr<_Tp>& Ptr<_Tp>::operator = (const Ptr<_Tp>& _ptr) template<typename _Tp> inline Ptr<_Tp>& Ptr<_Tp>::operator = (const Ptr<_Tp>& _ptr)
{ {
int* _refcount = _ptr.refcount; if (this != &_ptr)
if( _refcount ) {
CV_XADD(_refcount, 1); int* _refcount = _ptr.refcount;
release(); if( _refcount )
obj = _ptr.obj; CV_XADD(_refcount, 1);
refcount = _refcount; release();
obj = _ptr.obj;
refcount = _refcount;
}
return *this; return *this;
} }