generic-library/opencv
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix solveCubic

Browse Source 
The original solution did not handle correctly when delta = 0,
resulting as nan errors. I also wrote a test case to test solving
equation x^3 = 0 after fixing.
This commit is contained in:
Viet Dinh
2015-11-05 19:19:56 -05:00
parent 021ff0efa6
commit 68bcff26fb
2 changed files with 29 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
modules/core/test/test_math.cpp
View File

@@ -2329,6 +2329,17 @@ void Core_SolvePolyTest::run( int )
pass = pass && div < err_eps;
}
//test bug #5623 - solves equation x^3 = 0
cv::Mat coeffs_5623(4, 1, CV_64FC1);
cv::Mat r_5623(3, 1, CV_64FC2);
coeffs_5623.at<double>(0) = 1;
coeffs_5623.at<double>(1) = 0;
coeffs_5623.at<double>(2) = 0;
coeffs_5623.at<double>(3) = 0;
double prec_5623 = cv::solveCubic(coeffs_5623, r_5623);
pass = pass && r_5623.at<double>(0) == 0 && r_5623.at<double>(1) == 0 && r_5623.at<double>(2) == 0;
pass = pass && prec_5623 == 1;
if (!pass)
{
ts->set_failed_test_info(cvtest::TS::FAIL_INVALID_OUTPUT);