generic-library/msgpack
1
0
Fork 0
mirror of https://github.com/msgpack/msgpack-c.git synced 2025-10-29 20:59:46 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #31 from redboltz/fix_buffer_leak

Browse Source 
Fixed buffer leak bug.

In the case of the function next() returns true:
Whichever the argument result is holding the zone or not, the ownership of the zone always should be delegated from 'unpacker' to 'unpacked'.

In the case of the function next() returns false:
Whichever the argument result is holding the zone or not, the members of 'unpacked' should be reset.
This commit is contained in:
Takatoshi Kondo
2013-10-14 23:59:04 -07:00
parent 8a2c50c374 53ded063a0
commit dc1698eaf4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/msgpack/unpack.hpp
View File

@@ -226,12 +226,12 @@ inline bool unpacker::next(unpacked* result)
} }
if(ret == 0) { if(ret == 0) {
if (result->zone().get() != NULL) result->zone().reset(); result->zone().reset();
result->get() = object(); result->get() = object();
return false; return false;
} else { } else {
if (result->zone().get() != NULL) result->zone().reset( release_zone() ); result->zone().reset( release_zone() );
result->get() = data(); result->get() = data();
reset(); reset();
return true; return true;