Merge pull request #557 from obache/neatsrc/fix-char-subscripts-warnings

Make sure to pass `unsigned char` to `isprint()`
This commit is contained in:
Takatoshi Kondo 2017-01-13 14:15:15 +09:00 committed by GitHub
commit a933fa5892

View File

@ -122,7 +122,7 @@ static void msgpack_object_bin_print(FILE* out, const char *ptr, size_t size)
for (i = 0; i < size; ++i) { for (i = 0; i < size; ++i) {
if (ptr[i] == '"') { if (ptr[i] == '"') {
fputs("\\\"", out); fputs("\\\"", out);
} else if (isprint(ptr[i])) { } else if (isprint((unsigned char)ptr[i])) {
fputc(ptr[i], out); fputc(ptr[i], out);
} else { } else {
fprintf(out, "\\x%02x", (unsigned char)ptr[i]); fprintf(out, "\\x%02x", (unsigned char)ptr[i]);
@ -142,7 +142,7 @@ static int msgpack_object_bin_print_buffer(char *buffer, size_t buffer_size, con
ret = snprintf(aux_buffer, aux_buffer_size, "\\\""); ret = snprintf(aux_buffer, aux_buffer_size, "\\\"");
aux_buffer = aux_buffer + ret; aux_buffer = aux_buffer + ret;
aux_buffer_size = aux_buffer_size - ret; aux_buffer_size = aux_buffer_size - ret;
} else if (isprint(ptr[i])) { } else if (isprint((unsigned char)ptr[i])) {
if (aux_buffer_size > 0) { if (aux_buffer_size > 0) {
memcpy(aux_buffer, ptr + i, 1); memcpy(aux_buffer, ptr + i, 1);
aux_buffer = aux_buffer + 1; aux_buffer = aux_buffer + 1;