generic-library/msgpack
1
0
Fork 0
mirror of https://github.com/msgpack/msgpack-c.git synced 2025-05-22 21:40:04 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #347 from redboltz/update_comment

Browse Source 
Updated comments to describe #if !define(_MSC_VER) reason.
This commit is contained in:
Nobuyuki Kubota 2015-08-17 12:11:04 -07:00
commit 57b030a6dd
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/boost_fusion.cpp
View File

@ -140,11 +140,12 @@ BOOST_FUSION_ADAPT_STRUCT(
f3 // *3 f3 // *3
) )
// MSVC2015's std::tuple requires default constructor during 'as' process.
// It doesn't support Expression SFINAE yet, then 'as' is fallbacked to 'convert'.
// After MSVC would support Expression SFINAE, remove this guard.
#if !defined(_MSC_VER) #if !defined(_MSC_VER)
// boost::fusion's adaptor uses std::tuple.
// MSVC2015's std::tuple requires default constructor during 'as' process.
// I don't know why...
TEST(MSGPACK_BOOST, pack_convert_no_def_con) TEST(MSGPACK_BOOST, pack_convert_no_def_con)
{ {
std::stringstream ss; std::stringstream ss;

7
test/msgpack_cpp11.cpp
View File

@ -456,10 +456,13 @@ TEST(MSGPACK_NO_DEF_CON_PAIR, simple_buffer)
EXPECT_EQ(val1, val2); EXPECT_EQ(val1, val2);
} }
#if !defined(_MSC_VER)
// MSVC2015's std::tuple requires default constructor during 'as' process. // MSVC2015's std::tuple requires default constructor during 'as' process.
// I don't know why... // It doesn't support Expression SFINAE yet, then 'as' is fallbacked to 'convert'.
// After MSVC would support Expression SFINAE, remove this guard.
#if !defined(_MSC_VER)
TEST(MSGPACK_NO_DEF_CON_TUPLE, simple_buffer) TEST(MSGPACK_NO_DEF_CON_TUPLE, simple_buffer)
{ {
std::tuple<no_def_con, no_def_con, no_def_con_composite> val1 {1, 2, 3}; std::tuple<no_def_con, no_def_con, no_def_con_composite> val1 {1, 2, 3};