Luca Boccassi
ff1ebf6ff0
Problem: ci_build.sh make check is overly complex
...
Solution: simply run make VERBOSE=1 check instead of manually
checking for return value and cat'ing the log file. With VERBOSE, on
error the log file will be automatically printed.
2016-03-06 18:34:25 +00:00
Luca Boccassi
4366d7edf9
Problem: doc/Makefile.am ignores --without-docs
...
Solution: add the document files to the MAN_DOC and MAN_HTML targets
in doc/Makefile.am only if BUILD_DOC and INSTALL_MAN are set,
otherwise leave the targets empty to avoid errors in make distcheck.
2016-03-06 18:34:25 +00:00
Luca Boccassi
2d9e7b57f9
Problem: make dist does not tar up macros.hpp
...
Solution: add it to Makefile.am file list
2016-03-06 17:56:24 +00:00
Luca Boccassi
8a0a18a527
Merge pull request #1844 from opedroso/CMAKELIST_PRECOMP
...
Problem: CMakelist missing support for Windows Precompiled headers
2016-03-06 12:45:48 +00:00
Osiris
cd1dfb4092
Problem: CMakelist missing support for Windows Precompiled headers
...
Solution: Add precompiled flags to CMakeList.txt for faster compiles
+ bonus - removed compilation warning on Windows by adding
add_definitions (-D_WINSOCK_DEPRECATED_NO_WARNINGS)
2016-03-06 06:23:26 -06:00
Pieter Hintjens
2cd4c38b80
Merge pull request #1843 from opedroso/WINDOWS_MAKE_TEST
...
Problem: Tests do no build in Windows environment
2016-03-05 22:12:26 +02:00
Osiris
1c9cec227d
Problem: Tests do no build in Windows environment
...
Solution: Modified CMakelist.txt to build correctly for Windows
- corrected CMake required version to make sure it builds in
Ubuntu 14.04 LTS with no warnings.
2016-03-05 14:01:21 -06:00
Osiris
a911fa41b8
Problem: Tests do no build in Windows environment
...
Solution: Modified CMakelist.txt to build correctly for Windows
2016-03-05 11:23:23 -06:00
Pieter Hintjens
0916c17b3a
Merge pull request #1842 from opedroso/PRECOMPILED
...
Problem: Windows Build not using precompiled headers for all targets
2016-03-05 12:59:51 +02:00
Constantin Rack
72898a0ecc
Merge pull request #1841 from opedroso/MAKE_CLEAN
...
Problem: Added "make clean" to Windows build scripts
2016-03-05 11:51:06 +01:00
Osiris
224c0670ee
Problem: Windows Build not using precompiled headers for all targets
...
Solution: Enabled precompiled header settings in all targets
Before build time: ~6min 49 secs
Stop Time: Fri 03/04/2016 8:29:50.13
Start Time: Fri 03/04/2016 8:23:00.28
After build time: ~4min 19 secs
Stop Time: Fri 03/04/2016 12:12:10.24
Start Time: Fri 03/04/2016 12:07:51.78
2016-03-05 04:47:08 -06:00
Osiris
09d003aac0
Problem: Added "make clean" to Windows build scripts
...
Solution: Added ability to do equivalent of a "make clean" by executing:
O:\git\libzmq\builds\msvc\build>buildall.bat clean
Start Time: Fri 03/04/2016 14:33:56.50
Cleaning without libsodium
Cleaning ..\vs2013\libzmq.sln... ()
Platform=x86
Configuration=DynDebug
Configuration=DynRelease
Configuration=LtcgDebug
Configuration=LtcgRelease
Configuration=StaticDebug
Configuration=StaticRelease
Platform=x64
Configuration=DynDebug
Configuration=DynRelease
Configuration=LtcgDebug
Configuration=LtcgRelease
Configuration=StaticDebug
Configuration=StaticRelease
Cleaning complete: ..\vs2013\libzmq.sln
Stop Time: Fri 03/04/2016 14:34:01.84
Start Time: Fri 03/04/2016 14:33:56.50
A clean takes ~5 secs to complete.
2016-03-05 04:37:01 -06:00
Constantin Rack
d315eea707
Merge pull request #1839 from opedroso/master
...
Problem: Visual Studio Toolset was incorrectly set in VCXPROJ files
2016-03-04 21:18:30 +01:00
Luca Boccassi
ee31ea1348
Merge pull request #1838 from obache/neatsrc/fix-c-comment-style
...
Problem: Fix C++ style comment usage in C source
2016-03-04 09:41:29 +00:00
Luca Boccassi
693d6384b6
Merge pull request #1837 from obache/neatsrc/fix-test-portability
...
Problem: Fix unportable `==` operator for `test`
2016-03-04 09:41:15 +00:00
Luca Boccassi
3c4377b11d
Merge pull request #1836 from obache/neatsrc/heimdal
...
Problem: Fix build with Heimdal krb5
2016-03-04 09:40:44 +00:00
OBATA Akio
8c7c8ece2d
Problem: Fix C++ style comment usage in C source
2016-03-04 17:26:02 +09:00
OBATA Akio
55dad06cce
Problem: Fix unportable ==
operator for test
2016-03-04 17:17:04 +09:00
OBATA Akio
09e868b743
Problem: Fix build with Heimdal krb5
...
Solution:
* Check gssapi/gssapi_generic.h header file, it is not in Heimdal.
* Check libgssapi too, libgssapi_krb5 is not separated in Heimdal.
2016-03-04 16:38:57 +09:00
Pieter Hintjens
36abdf7bd5
Merge pull request #1834 from garlick/config_nacl
...
minor automake fixes plus tweetnacl logic change
2016-03-02 23:16:25 +01:00
Jim Garlick
54389fefb5
Problem: AS_HELP_STRING improperly quoted
...
Brackets around defaults in configure --help strings for
--with-libsodium and --disable-curve were not displayed.
Solution: Add m4 quotes.
2016-03-02 12:11:08 -08:00
Jim Garlick
9d75a9c27d
Problem: AM_CONDITIONAL is used incorrectly
...
Move AM_CONDITIONAL for --disable-curve outside of shell
conditional (per sec 20.1 of automake manual) and fix its
second argument to be a test rather than a literal zero.
2016-03-02 11:28:42 -08:00
Luca Boccassi
ec6209737e
Merge pull request #1832 from hintjens/master
...
Problem: can't be sure crypto_box always returns 0
2016-03-01 15:53:26 +00:00
Pieter Hintjens
5b7bf7509f
Problem: can't be sure crypto_box always returns 0
...
Libsodium has started returning -1 in some cases.
Solution: allow and handle error returns from these calls.
Fixes #1831
2016-03-01 15:01:23 +01:00
Joe Eli McIlvain
708c2060ee
Merge pull request #1830 from stevenc99/master
...
include sys/ucred.h for struct ucred
2016-02-28 13:50:58 -08:00
Steven Chamberlain
dd8ccd5e0f
include sys/ucred.h for struct ucred
...
Platforms that have struct ucred, typically declare it in sys/ucred.h
2016-02-28 20:42:54 +00:00
Pieter Hintjens
d7691756e2
Merge pull request #1829 from dflupu/master
...
update Makefile.mingw32
2016-02-28 08:25:59 +01:00
Daniel Lupu
3190de8045
update Makefile.mingw32
2016-02-28 06:26:35 +02:00
Pieter Hintjens
8b32073c7b
Merge pull request #1826 from bluca/make_dist
...
Problem: make dist is borken
2016-02-22 13:36:21 +01:00
Luca Boccassi
b3b9cfd92e
Problem: packaging/redhat/zeromq.spec not ignored
...
Solution: add it to .gitignore
2016-02-22 11:59:51 +00:00
Luca Boccassi
f3686e34ff
Problem: make dist broken due to builds/msvc
...
Solution: change builds/msvc/Makefile.am to reference vcxproj files
instead of props files.
2016-02-22 11:58:36 +00:00
Luca Boccassi
391397571b
Problem: make dist broken due to builds/android
...
Solution: change builds/Makefile.am to reference builds/android
instead of builds/qt-android.
2016-02-22 11:58:00 +00:00
Luca Boccassi
8d811474d4
Problem: make dist broken due to builds/cmake
...
Solution: remove references to builds/cmake/Makefile* since they no
longer exist.
2016-02-22 11:57:09 +00:00
Constantin Rack
232094a09d
Merge pull request #1825 from bluca/whitespace_and_werror
2016-02-22 07:27:36 +01:00
Luca Boccassi
80e529a16a
Problem: all tests fail with assert in in_event
...
Solution: socket_base_t::in_event cannot do anything useful with
return status of process_commands. Asserting is the wrong solution,
as it is entirely valid to be interrupted or for the context to be
terminated, so discard the value.
2016-02-22 00:05:52 +00:00
Luca Boccassi
ae8efc21e8
Problem: nullptr is a reserved keyword in C++0x
...
Solution: use NULL instead to avoid build failure with older
compilers.
2016-02-21 23:54:18 +00:00
Luca Boccassi
7187169619
Problem: socket_poller_t initialization reorder
...
Solution: initialize class variable in the same order as they are
defined.
2016-02-21 23:50:34 +00:00
Luca Boccassi
c84a52b11e
Problem: udp_engine_t fd cannot be init to NULL
...
Solution: initialize to -1, since fd is a file descriptor (int).
2016-02-21 23:47:44 +00:00
Luca Boccassi
1046f35930
Problem: udp_engine_t initialization reorder
...
Solution: initialize class variable in the same order as they are
defined.
2016-02-21 23:46:51 +00:00
Luca Boccassi
24b84081be
Problem: socks_connecter_t initialization reorder
...
Solution: initialize class variable in the same order as they are
defined.
2016-02-21 23:45:02 +00:00
Luca Boccassi
a6e49860f5
Problem: tcp_connecter_t initialization reorder
...
Solution: initialize class variable in the same order as they are
defined.
2016-02-21 23:43:09 +00:00
Luca Boccassi
645c2be487
Problem: stream_engine_t initialization reorder
...
Solution: initialize class variable in the same order as they are
defined.
2016-02-21 23:42:12 +00:00
Luca Boccassi
c21dd8d6a2
Problem: socket_base_t initialization reorder
...
Solution: initialize class variable in the same order as they are
defined.
2016-02-21 23:41:02 +00:00
Luca Boccassi
acbf021a7c
Problem: reaper_t initialization reorder
...
Solution: initialize class variable in the same order as they are
defined.
2016-02-21 23:39:09 +00:00
Luca Boccassi
779bed6315
Problem: encoder_base_t initialization reorder
...
Solution: initialize class variable in the same order as they are
defined.
2016-02-21 23:37:10 +00:00
Luca Boccassi
de46fc6ac9
Problem: can't do anything with load.sub ret val
...
Solution: don't store it in zmq::poller_base_t::adjust_load, as the
build with Werror=unused=variable will fail otherwise.
2016-02-21 23:28:54 +00:00
Luca Boccassi
14054d28ed
Problem: can't statically initialized pthread_t
...
Solution: remove statc initialization to NULL of thread.hpp pthread_t
descriptor. There is no portable way to statically initialize a
pthread_t variable.
2016-02-21 23:26:01 +00:00
Luca Boccassi
cf309a4e8c
Problem: maxfd definition depends on ifdef
...
Solution: initialise it inside an ifdef too
2016-02-21 23:17:28 +00:00
Luca Boccassi
d4c0716473
Problem: indentation should be 4 spaces, no tabs
...
Solution: fix it
2016-02-21 23:16:44 +00:00
Constantin Rack
406b5738b6
Merge pull request #1823 from opedroso/COVERITY
...
Problem: Several problems found by Coverity Static Analyzer
2016-02-21 22:56:46 +01:00