generic-library/libzmq
1
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-03-03 21:06:28 +01:00
Code Issues Projects Releases Wiki Activity
6,893 Commits 4 Branches 39 Tags
Commit Graph

2743 Commits

Author SHA1 Message Date
Simon Giesecke
c9d6ef3035 Problem: Member outpipes is duplicate between router_t and stream_t 
Solution: extract into common base class routing_socket_base_t, for now as protected
 2018-05-29 15:05:26 +02:00
Simon Giesecke
728eddfcfd Problem: socket_base_t::connect_routing_id is protected and only used in router_t and stream_t 
Solution: add an intermediary base class routing_socket_base_t, move common functionality there and make connect_routing_id private
 2018-05-29 15:05:26 +02:00
Simon Giesecke
25461a78dd Problem: members of mechanmism_t are needlessly protected 
Solution: make them private
 2018-05-29 11:08:22 +02:00
Simon Giesecke
47dcd84f21 Problem: C-style casts 
Solution: replace by reinterpret_casts or avoid entirely
 2018-05-28 18:47:07 +02:00
Simon Giesecke
917a4a8e10 Problem: reinterpret_casts between unsigned char* and char* 
Solution: use char* from the beginning
 2018-05-28 18:47:07 +02:00
Simon Giesecke
0a43c66a32 Problem: magic literals in zap_client.cpp 
Solution: extracted constants
 2018-05-28 18:47:07 +02:00
Simon Giesecke
7c2d1c1824 Problem: magic literals for UCHAR_MAX 
Solution: use UCHAR_MAX constant instead
 2018-05-28 18:46:50 +02:00
Simon Giesecke
a4c817e736 Problem: magic number "2" in socket_base.cpp 
Solution: calculate from field sizes
 2018-05-28 18:45:41 +02:00
Simon Giesecke
d75ec5e055 Problem: produce_* functions always return 0 
Solution: change return type to void, and remove redundant result checks
 2018-05-28 17:53:46 +02:00
Simon Giesecke
7f880c256f Problem: magic numbers and data duplication in plain_*.cpp 
Solution: extract constants / move to plain_common.hpp
 2018-05-28 17:53:46 +02:00
Simon Giesecke
8269b23e56 Problem: magic numbers and code duplication in msg.cpp 
Solution: extract constants and unified cases
 2018-05-28 17:53:44 +02:00
Simon Giesecke
18000a213f Problem: magic numbers in mechanism_base.cpp 
Solution: extract constants
 2018-05-28 17:53:44 +02:00
Simon Giesecke
abca9f6bc1 Problem: Magic numbers in plain_server.cpp 
Solution: introduced constants
 2018-05-28 17:53:44 +02:00
Simon Giesecke
2da6629e0f Problem: Magic numbers "1" and "100" in signaler.cpp 
Solution: introduced constants, use std::min/std::max instead of control structures
 2018-05-28 17:53:43 +02:00
Simon Giesecke
a6060674b4 Problem: Magic numbers "32" and "128" in tcp_address.cpp 
Solution: introduced constants
 2018-05-28 17:53:43 +02:00
Simon Giesecke
93e75fd695 Problem: Magic numbers "6" and "7" in null_mechanism.cpp 
Solution: introduced constants
 2018-05-28 17:53:42 +02:00
Simon Giesecke
c05db7f025 Problem: Magic numbers "1" and "6" in null_mechanism.cpp 
Solution: introduced constants
 2018-05-28 17:53:42 +02:00
Simon Giesecke
ff27dd01f0 Problem: Magic numbers "1" and "4" in mechanism.cpp 
Solution: introduced constants
 2018-05-28 17:53:42 +02:00
Simon Giesecke
7c9d058cdb Problem: Magic number "2" in ip_resolver.cpp 
Solution: introduced constant
 2018-05-28 17:53:41 +02:00
Simon Giesecke
16bb62e6f7 Problem: ctx_t::_slots is a plain array 
Solution: use a std::vector instead
 2018-05-28 17:53:41 +02:00
Simon Giesecke
a0a60e80ca Problem: Magic number "2" in ctx.cpp 
Solution: introduced constant
 2018-05-28 17:53:40 +02:00
Luca Boccassi
624c142365 Problem: static analysis warning about ifdef typo 
Solution: fix it
 2018-05-28 12:32:23 +01:00
Simon Giesecke
d767909b50 Problem: old C-style casts used 
Solution: replace by static_cast/reinterpret_cast
 2018-05-27 13:24:07 +02:00
Simon Giesecke
e3c73d9881 Problem: inconsistent naming style for private data members, conflicts with naming of local variables and member functions 
Solution: apply and check _lower_case naming style for private data members
 2018-05-27 13:24:07 +02:00
Simon Giesecke
06cfd0d8ad Problem: unclear why QueryPerformanceFrequency is called for every call of QueryPerformanceCounter 
Solution: add a comment
 2018-05-27 13:24:07 +02:00
Simon Giesecke
97ba02bc2f Problem: redundant empty dtor 
Solution: removed
 2018-05-27 13:24:06 +02:00
Simon Giesecke
6ef67f13e3 Problem: use of C-style casts and magic literals 
Solution: replace by static_cast, and introduce appropriate constants
 2018-05-27 13:24:06 +02:00
Simon Giesecke
37344d0b7c Problem: redundant old-style void argument declarations 
Solution: remove
 2018-05-26 09:34:45 +02:00
Simon Giesecke
12a97bb769 Problem: redundant else after return 
Solution: remove else
 2018-05-26 09:34:45 +02:00
Simon Giesecke
21498700ef Problem: integer literals assigned to bool variables 
Solution: replace by bool literals
 2018-05-26 09:34:45 +02:00
Simon Giesecke
eacc805646 Problem: complex unnecessary ternary expressions 
Solution: simplify to comparison against 0
 2018-05-26 09:34:44 +02:00
Simon Giesecke
1432011277 Problem: inconsistent local variable naming 
Solution: configured clang-tidy check and applied fixes
 2018-05-26 09:34:44 +02:00
Simon Giesecke
c581f43c97 Problem: parameter naming style inconsistent 
Solution: define and apply parameter naming style: lower_case_
 2018-05-26 09:34:44 +02:00
Simon Giesecke
763760988f Problem: VS2008 has no definition of UINT16_MAX 
Solution: provide definition based on _UI16_MAX
 2018-05-25 15:13:07 +02:00
Simon Giesecke
d90e70c1cf Problem: maximum allowed value for ZMQ_HEARTBEAT_TTL is wrong 
Solution: use UINT16_MAX
 2018-05-25 15:06:11 +02:00
Simon Giesecke
2ae0c4e2c5 Problem: unnecessarily complex inheritance hierarchy in decoders, warning C4355 with VS2010 
Solution: make allocator a member of decoder_base_t
 2018-05-24 15:17:08 +02:00
Simon Giesecke
082b6aa641 Problem: epoll not supported under Windows 
Solution: Use wepoll on Windows
 2018-05-23 16:25:07 +02:00
Luca Boccassi
3730833f9d
Merge pull request #3125 from sigiesec/improve-socket-inheritance 
Improve socket inheritance handling
 2018-05-23 13:50:39 +01:00
Simon Giesecke
2d9a8955f5 Problem: race condition in making socket non-inheritable 
Solution: create sockets with WSA_FLAG_NO_HANDLE_INHERIT
 2018-05-23 11:23:33 +02:00
Simon Giesecke
44da0e7e42 Problem: code duplication in making sockets non-inheritable 
Solution: extracted make_socket_noninheritable function
 2018-05-23 11:23:33 +02:00
Simon Giesecke
c432aada84 Problem: inconsistent error handling and unnecessary code duplication 
Solution: make error handling consistent and use retired_fd to remove code duplication
 2018-05-23 11:23:33 +02:00
Luca Boccassi
44b0753c5c
Merge pull request #3047 from acsearle/master 
Allow EBADF on iOS #3046
 2018-05-23 09:56:32 +01:00
Luca Boccassi
d02ba13576
Merge pull request #3122 from sigiesec/test-migrations 
Migrated some more tests to unity and fixed some more code style issues
 2018-05-22 20:37:34 +01:00
Simon Giesecke
440be28d7e Problem: unnecessary non-const variables 
Solution: add const
 2018-05-22 18:46:40 +02:00
Simon Giesecke
d6952ded71 Problem: unused include directives and redundant forward declarations 
Solution: removed
 2018-05-22 18:46:40 +02:00
Simon Giesecke
04ec6aaf28 Problem: malloc call may fail 
Solution: add alloc_assert
 2018-05-22 18:46:40 +02:00
Simon Giesecke
d326434b37 Problem: API poller cannot be set independently from I/O thread poller, poll I/O thread poller broken on Windows 
Solution: change platform definitions to separate API poller from I/O thread poller, disallow configuring poll I/O thread poller on Windows
 2018-05-22 18:36:04 +02:00
Simon Giesecke
4e616f30dd Problem: C-style casts used 
Solution: replace by C++-style casts
 2018-05-18 17:04:01 +02:00
Simon Giesecke
d002eb5578 Problem: analyzer does not know that zmq_abort does not return 
Solution: add no-return attributes
 2018-05-18 16:25:24 +02:00
Simon Giesecke
7b3acd47b2 Problem: malloc may fail in blob_t ctors 
Solution: add alloc_assert calls
 2018-05-18 16:25:24 +02:00