sigiesec
|
11b3c93852
|
Problem: console output for PLAIN protocol errors
Solution: emit socket monitor events for PLAIN protocol errors (like CURVE)
|
2017-08-18 09:18:06 +02:00 |
|
sigiesec
|
e2d3ba9c62
|
Problem: classification ZMQ_HANDSHAKE_FAILED_* events is coarse-grained and partially misleading
Solution: redesign ZMQ_HANDSHAKE_FAILED_* events, introduce new class of ZMQ_HANDSHAKE_FAILED_AUTH events
|
2017-08-18 09:17:59 +02:00 |
|
sigiesec
|
f9985708b7
|
Problem: unreachable code in zap_client_t
Solution: replaced unreachable code by assertions and adapted uses
|
2017-08-17 12:54:05 +02:00 |
|
sigiesec
|
f107b53768
|
Problem: deviating behavior regarding monitoring events between mechanisms
Solution: move relevant behavior to zap_client_t
|
2017-08-17 12:10:00 +02:00 |
|
sigiesec
|
8dce0396fb
|
Problem: inconsistent handling of ZAP replies
Solution: unification, pulled up common behaviour to zap_client_t/zap_client_common_handshake_t
|
2017-08-17 09:44:05 +02:00 |
|
sigiesec
|
8c58ef7f5c
|
Problem: zap_msg_available duplicated between curve_server_t and plain_server_t (with deviating behaviour)
Solution: pull up into zap_client_common_handshake_t, along with handle_zap_status_code and error_detail/current_error_detail
|
2017-08-16 18:05:36 +02:00 |
|
sigiesec
|
314a3acfa9
|
Problem: status method duplicated between curve_server_t and plain_server_t
Solution: extract into new intermediate base class zap_client_common_handshake_t
|
2017-08-16 18:05:36 +02:00 |
|
sigiesec
|
414c6f45b8
|
Problem: receive_and_process_zap_reply is duplicated in all mechanisms
Solution: extract receive_and_process_zap_reply into zap_client_t and convert zap_client_t into base class of the server mechanism classes
|
2017-08-16 18:05:35 +02:00 |
|
sigiesec
|
d7a3778387
|
Problem: plain_server_t duplicates zap_client_t::send_zap_request
Solution: Use zap_client_t::send_zap_request
|
2017-08-16 18:05:35 +02:00 |
|
sigiesec
|
014b201d3e
|
Problem: ZAP message without credentials is not terminated
Solution: Set more flag depending on presence of credentials
|
2017-08-16 18:05:35 +02:00 |
|
sigiesec
|
b324c66b6f
|
Problem: null_mechanism duplicates zap_client_t::send_zap_request\nSolution: use zap_client_t::send_zap_request
|
2017-08-16 18:05:34 +02:00 |
|
sigiesec
|
6e8a0b31be
|
Problem: ZAP client code is duplicated in all mechanisms
Solution: created a zap_client_t class, extracted first function send_zap_request from curve_server_t
|
2017-08-16 18:04:30 +02:00 |
|