Commit Graph

3580 Commits

Author SHA1 Message Date
Martin Hurton
21e20127b6 Merge pull request #1171 from hintjens/master
Problem: nodrop code is ugly
2014-08-27 13:58:56 +02:00
Pieter Hintjens
f15146b5d2 Problem: nodrop code is ugly
It's bad practice to start by testing all exceptional conditions
and then dropping through to the 'normal' condition. Apart from
being inefficient, it's deceptive to the user. Conditional code
should always try to show the natural expectation of the code,
with exceptional cases coming last.

Solution: clean up this code.
2014-08-27 13:51:25 +02:00
Martin Hurton
128bed472b Merge pull request #1170 from hintjens/master
Fixed issues with xpub nodrop property
2014-08-27 13:25:27 +02:00
Pieter Hintjens
2584c3a724 Added test cases to .gitignore 2014-08-27 12:06:54 +02:00
Pieter Hintjens
35040aaf18 Problem: issues with nodrop property
- not initialized before use
- name is nasty (boolean variables should not have negative names)

Solution: rename to 'lossy' and initialize to 'true'.
2014-08-27 12:06:54 +02:00
Pieter Hintjens
81485c7688 Merge pull request #1168 from ricnewton/master
Fix test broken when we changed FD_SETSIZE.
2014-08-26 11:14:09 +02:00
Richard Newton
8926cb3ddb Fix test broken when we changed FD_SETSIZE. 2014-08-26 08:36:51 +01:00
Richard Newton
3811b0b1ef Merge pull request #1166 from hintjens/master
Problem: FD_SETSIZE 1024 is too restrictive under Windows
2014-08-26 08:29:47 +01:00
Pieter Hintjens
1acc1b1582 Problem: FD_SETSIZE 1024 is too restrictive under Windows
Solution: increased to 4096 by default for all MSVC builds, for MinGW,
and for CMake.

Note: this is a speculative change, it needs confirmation before we
can keep it. Particularly, there is some doubt that changing this in
libzmq will affect upstream applications using libzmq.dll.
2014-08-23 13:59:53 +02:00
Pieter Hintjens
72b8a19691 Merge pull request #1163 from hurtonm/master
Code cleanup
2014-08-14 10:10:10 +02:00
Martin Hurton
f550d66ae3 Code cleanup 2014-08-14 08:58:01 +02:00
Pieter Hintjens
b817f3c61e Merge pull request #1162 from xaqq/encode_decode
Add const qualifier to source parameters for z85 encode/decode
2014-08-14 07:33:24 +02:00
Kapp Arnaud
fbdc5aa22d Add const qualifier to source parameters in zmq_z85_decode and zmq_z85_encode 2014-08-14 00:00:00 +02:00
Pieter Hintjens
fadb2a38d9 Merge pull request #1161 from hurtonm/master
Reset metadata for outbound messages
2014-08-13 09:21:46 +02:00
Martin Hurton
a54d8d7b0c Reset metadata for outbound messages 2014-08-13 08:53:54 +02:00
Pieter Hintjens
25de6a03ac Merge pull request #1159 from kreuzberger/master
Bugfix wrong CMakeLists.txt after rename of file
2014-08-13 06:12:29 +02:00
kreuzberger
212220dda7 Bugfix wrong CMakeLists.txt after rename of file 2014-08-12 21:34:30 +02:00
Martin Hurton
ea719a8dff Merge pull request #1151 from hintjens/master
Documentation patches
2014-08-12 14:04:34 +02:00
Pieter Hintjens
f20b70bef5 Cleaned up test_xpub_nodrop
Renamed test case to actually explain what it's testing, and cleaned up
the code a little.
2014-08-12 12:37:49 +02:00
Pieter Hintjens
a7fed989a6 Minor changes to Travis CI script 2014-08-12 12:37:49 +02:00
Pieter Hintjens
785aebc6a8 Reworking Travis script 2014-08-12 12:37:49 +02:00
Pieter Hintjens
75d4f50be3 Problem: ZMQ_CURVE_SECRETKEY reads beyond end of Z85 data
Solution: change setsockopts on printable keys to expect 41, nor 40
bytes. Code still accepts 40 bytes for compatibility, and copies the
key to a well-terminated string before using it.

Fixes #1148
2014-08-12 12:37:49 +02:00
Pieter Hintjens
0dcf6b5e2b Added AppDynamics as corporate author 2014-08-12 12:37:49 +02:00
Pieter Hintjens
2c5baff95f Note that ZMQ_TCP_ACCEPT_FILTER is deprecated 2014-08-12 12:37:49 +02:00
Pieter Hintjens
acc4fe8794 Merge pull request #1158 from hurtonm/master
Code cleanup
2014-08-12 12:32:24 +02:00
Martin Hurton
214553972d Return -1 when failed to publish message 2014-08-12 10:51:37 +02:00
Martin Hurton
228426ac44 Code cleanup 2014-08-12 09:31:19 +02:00
Pieter Hintjens
bb6d18d5a2 Merge pull request #1156 from kreuzberger/master
Provide socket option for pub sockets to not silently drop message
2014-08-09 00:52:21 +02:00
kreuzberger
f042ea9e26 better naming of flags and variables to real functionality: nodrop 2014-08-08 19:45:41 +02:00
kreuzberger
d9a3cc48d4 do not silently drop messages in publisher if hwm is reached 2014-08-08 19:36:00 +02:00
Pieter Hintjens
446e8efb07 Merge pull request #1155 from mrvn/pull-document_hwm_behaviour_with_ZMQ_ROUTER_MANDATORY
Document altered HWM behaviour when ZMQ_ROUTER_MANDATORY is set.
2014-08-07 13:29:14 +02:00
Goswin von Brederlow
da6cf63857 Document altered HWM behaviour when ZMQ_ROUTER_MANDATORY is set. 2014-08-07 13:16:12 +02:00
Pieter Hintjens
bbbe8d7832 Merge pull request #1154 from mrvn/pull-test_router_mandatory_hwm
Add test for HWM behaviour for mandatory ROUTER sockets over tcp
2014-08-07 13:09:54 +02:00
Goswin von Brederlow
893995e698 Add test for HWM behaviour for mandatory ROUTER sockets over tcp 2014-08-07 12:52:07 +02:00
Pieter Hintjens
0f780ef733 Merge pull request #1152 from drodri/task/cmake_structure
moved root CMakeLists.txt tests config to tests/CMakeLists.txt
2014-08-05 13:37:37 +02:00
Diego
6537e202d6 moved root CMakeLists.txt tests config to tests/CMakeLists.txt 2014-08-05 13:24:32 +02:00
Pieter Hintjens
0c4ee0a9b0 Merge pull request #1147 from rodgert/master
Update zmq_msg_get(ZMQ_SHARED) to return true for type_cmsg messages
2014-07-29 21:12:24 +02:00
Thomas Rodgers
03f097a541 Update zmq_msg_get(ZMQ_SHARED) to return true for type_cmsg messages 2014-07-29 13:43:38 -05:00
Pieter Hintjens
416ee8e75c Merge pull request #1146 from minrk/utf8-metadata
define encoding for message metadata to be UTF8
2014-07-29 01:02:43 +02:00
Pieter Hintjens
10a2e6c24d Merge pull request #1145 from pijyoi/master
use enum retired_fd instead of -1
2014-07-28 22:29:09 +02:00
MinRK
4406329100 define encoding for message metadata to be UTF8
clarifies that these are text fields,
and removes ambiguity about how to create proper
text object from stored bytes.
2014-07-28 13:23:56 -07:00
KIU Shueng Chuan
6bcced7537 use enum retired_fd instead of -1 2014-07-29 04:16:44 +08:00
Trevor Bernard
ac99d50abb Merge pull request #1142 from hintjens/master
Problem: does not install man pages correctly when out of tree
2014-07-25 16:49:34 -03:00
Pieter Hintjens
cdbe557727 Problem: does not install man pages correctly when out of tree
Solution: fix Makefile.am

As per Richard Sharpe on zeromq-dev.
2014-07-25 21:39:51 +02:00
Pieter Hintjens
817912d795 Merge pull request #1139 from ewen-naos-nz/zos
z/OS: Updated to build libzmq git master
2014-07-25 00:40:15 +02:00
Ewen McNeill
326dec067f z/OS: Updated portability notes
Updated:
    builds/zos/README.md: Updated with portability notes resulting
       from building zeromq/libzmq/master as of 2014-07-23 on z/OS
       UNIX System Services.

       Current z/OS UNIX status: all expected tests pass, except
       "test_proxy", which hangs and times out.
2014-07-24 14:48:49 +12:00
Ewen McNeill
f1cd2055de z/OS: chmod +x builds/zos/{cxxall,runtests} 2014-07-24 14:13:59 +12:00
Ewen McNeill
256c32d1fb z/OS: builds/zos/platform.hpp for libzmq 4.1.0 2014-07-24 14:06:00 +12:00
Ewen McNeill
501666d07e z/OS: Skip pthread_{get,set}schedparam
Updated:
    src/thread.cpp: On older z/OS UNIX System Services,
        pthread_{get,set}schedparam is not present (searching the
        Internet suggests it may be present in later version than
        the one being used for z/OS UNIX System Services porting).

        Make zmq::thread_t::setSchedulingParameters() a no-op on
        z/OS UNIX System Services.

    NOTE: pthread_{get,set}schedparam appear to have been introduced
    by POSIX.1-2001 or IEEE 1003.1-2004 so may not be universally
    available, and thus more platforms may need this "no-op" treatment.
2014-07-24 13:54:21 +12:00
Ewen McNeill
b27bafff60 z/OS: Autodetect tests to run
Updated:
    builds/zos/runtests: Extract tests to run from tests/Makefile.am
      at runtime, rather than hard coding tests list (to simplfy
      later maintenance).  test_*_tipc is excluded as BUILD_TIPC is
      not defined on z/OS UNIX System Services.  XFAIL_TESTS are also
      excluded, following current logic in tests/Makefile.am
2014-07-24 13:50:38 +12:00