6885 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Simon Giesecke	987e75b887	Problem: test program test_unbind_inproc is redundant, the same is already tested in test_inproc_connect ... Solution: remove test_unbind_inproc	2018-08-16 12:37:06 +02:00
Simon Giesecke	f6a3ebde99	Problem: test not using unity assertions and test utils ... Solution: Migrate to unity assertions and test utils	2018-08-16 11:55:07 +02:00
Simon Giesecke	a9973ac43f	Problem: /Z7 debug info is used only for Debug build, but not for RelWitDebInfo build ... Solution: apply the same commadn for RelWithDebInfo build	2018-08-16 11:40:55 +02:00
Simon Giesecke	6824c167ad	Merge pull request #3217 from WenbinHou/patch-1 ... Update unittests/CMakeLists.txt: use ZeroMQ_SOURCE_DIR, ZeroMQ_BINARY_DIR	2018-08-16 11:15:44 +02:00
Simon Giesecke	75e4a342e2	Problem: XFAIL_TESTS does not correctly reference some tests ... Solution: add tests/ directory prefix	2018-08-16 11:07:05 +02:00
Wenbin Hou	0507ae877d	Update tests/CMakeLists.txt: use ZeroMQ_SOURCE_DIR, ZeroMQ_BINARY_DIR ... Use ZeroMQ_SOURCE_DIR, ZeroMQ_BINARY_DIR instead of CMAKE_SOURCE_DIR, CMAKE_BINARY_DIR in tests/CMakeLists.txt Similar reason to change unittests/CMakeLists.txt	2018-08-16 13:17:44 +08:00
Wenbin Hou	8fbb32c8f1	RELICENSE: Wenbin Hou ... Create RELICENSE/WenbinHou.md	2018-08-16 08:46:48 +08:00
Simon Giesecke	c546045d8c	Problem: test_connect_delay_tipc not yet using unity ... Solution: started migration to unity (run test cases separately)	2018-08-15 18:35:17 +02:00
Simon Giesecke	06a9d809aa	Problem: test_connect_delay_tipc is almost always failing ... Solution: add to XFAIL_TESTS until resolved	2018-08-15 15:27:37 +02:00
Simon Giesecke	6d7aeb056f	Problem: complexity of start_connecting ... Solution: extract functions for each protocol	2018-08-15 14:46:21 +02:00
Simon Giesecke	2cd34da1b0	Problem: code duplication in session_base_t::start_connecting ... Solution: extract common code	2018-08-15 14:46:21 +02:00
Simon Giesecke	799fae44fe	Problem: magic literal used for inproc ... Solution: define and use named constant	2018-08-15 14:46:21 +02:00
Simon Giesecke	daadb65a46	Problem: inconsistency of using terms address and uri ... Solution: use terms more consistently	2018-08-15 14:46:21 +02:00
Simon Giesecke	cdc6c66f9b	Problem: complexity of term_endpoint ... Solution: extract resolve_tcp_addr function	2018-08-15 14:46:21 +02:00
Simon Giesecke	a2d736c14f	Problem: functionality around inprocs_t is scattered ... Solution: extract into functions of new inprocs_t class	2018-08-15 14:46:21 +02:00
Simon Giesecke	fb576d2f95	Problem: unnecessary procedural code ... Solution: replace by functional expression	2018-08-15 14:46:21 +02:00
Simon Giesecke	3455be144d	Problem: code duplication around sending of routing id ... Solution: extract functionality into send_routing_id	2018-08-15 14:46:21 +02:00
Simon Giesecke	83f41526c9	Problem: code duplication around options_t::conflate ... Solution: extract functionality into get_effective_conflate_option	2018-08-15 12:18:35 +02:00
Simon Giesecke	8820dedcb7	Problem: stream_engine_t::_as_server is not used ... Solution: remove it	2018-08-15 11:53:31 +02:00
Simon Giesecke	0852099f67	Problem: unused field pipe_t::_credentials ... Solution: remove it	2018-08-15 11:48:00 +02:00
Szekely Gyorgy	2cdad3d0ce	Add ZMQ_ROUTER_NOTIFY draft socket option (#3213) ... * Add ZMQ_ROUTER_NOTIFY draft socket option	2018-08-15 08:54:08 +01:00
Luca Boccassi	4738bed5b6	Merge pull request #3219 from hoditohod/relicense ... RELICENSE: Szekely Gyorgy	2018-08-15 08:50:05 +01:00
Gyorgy Szekely	69d69f21a8	RELICENSE: Szekely Gyorgy	2018-08-15 09:37:59 +02:00
Wenbin Hou	c981336445	Udpate unittests/CMakeLists.txt: use ZeroMQ_SOURCE_DIR, ZeroMQ_BINARY_DIR ... Use ZeroMQ_SOURCE_DIR, ZeroMQ_BINARY_DIR instead of CMAKE_SOURCE_DIR, CMAKE_BINARY_DIR, which allows libzmq to become an "add_subdirectory" target (with static build). Otherwise, building unittest_xxx would complain header files not found.	2018-08-15 10:11:49 +08:00
Luca Boccassi	cbb9925a10	Merge pull request #3215 from sigiesec/remove-unused-get-credential ... Problem: unused get_credential methods and associated fields	2018-08-14 20:05:53 +01:00
Luca Boccassi	dbe289509e	Merge pull request #3211 from sigiesec/migrate-and-extend-probe-router-test ... Migrate and extend probe router test	2018-08-13 17:40:07 +01:00
Simon Giesecke	da30ff7d3d	Problem: unused get_credential methods and associated fields ... Solution: remove them	2018-08-13 15:22:18 +02:00
Simon Giesecke	062b510b5d	Problem: test case test_probe_router_router does not receive auto-generated routing id ... Solution: add receive call for routing id	2018-08-13 13:26:50 +02:00
Luca Boccassi	0b1589dbba	Merge pull request #3209 from sigiesec/code-improvements ... Code style improvements	2018-08-10 16:40:23 +01:00
Simon Giesecke	d78152bf83	Problem: no test case for ZMQ_PROBE_ROUTER on ZMQ_DEALER socket ... Solution: add test case	2018-08-10 17:30:23 +02:00
Simon Giesecke	d9e5ba671b	Problem: test_probe_router not yet using unity ... Solution: migrate to unity/testutil_unity	2018-08-10 17:30:00 +02:00
Simon Giesecke	bbae67df89	Code style improvements	2018-08-10 15:36:31 +02:00
Simon Giesecke	b102e30419	Fixed naming for filter parameter, removed unnecessary temporary variable, fixed naming of local variable	2018-08-10 11:25:20 +02:00
Simon Giesecke	a1b6268c83	Made to_string const; converted C-style cast to reinterpret_cast	2018-08-10 11:25:09 +02:00
Luca Boccassi	6e8424ab5d	Merge pull request #3206 from sigiesec/fix-zap-memory-use-after-free ... Problem: stream_engine_t instance may access its fields after it deleted itself	2018-08-09 18:17:58 +01:00
Simon Giesecke	737927e333	Fixed spelling of parameter	2018-08-09 18:27:01 +02:00
Simon Giesecke	46ed0920b2	Various code style improvements	2018-08-09 18:27:01 +02:00
Luca Boccassi	53e9af71af	Merge pull request #3208 from sigiesec/add-clang-rule-exclusions-analyze ... Added some more clang-tidy rule exclusions	2018-08-09 16:36:26 +01:00
Simon Giesecke	bfa8275cfb	Added some more clang-tidy rule exclusions	2018-08-09 15:44:46 +02:00
Simon Giesecke	563651e0c9	Problem: stream_engine_t instance may access its fields after it deleted itself ... Solution: prevent access to data if the object was deleted	2018-08-09 15:24:23 +02:00
Luca Boccassi	76602516a8	Merge pull request #3205 from sigiesec/code-improvements ... Code style improvements	2018-08-09 13:39:07 +01:00
Simon Giesecke	be81dcd4d3	Use std::min/max where possible	2018-08-09 12:53:32 +02:00
Simon Giesecke	3cb77e423e	Use revision_pos constant	2018-08-09 12:47:18 +02:00
Simon Giesecke	758f903db4	Some code style improvements: removed redundant parentheses, added const, joined declaration and assignment of local variables	2018-08-09 12:41:08 +02:00
Simon Giesecke	89e5313114	Refactored zmq::stream_engine_t::handshake, extracted several sub-methods	2018-08-09 12:41:08 +02:00
Simon Giesecke	c3739ff604	Use static_cast instead of C-style casts, make local variables const where possible, use switch instead of chained if/else, extract rm_helper_multiple_subnodes from rm_helper to reduce nesting	2018-08-09 12:41:08 +02:00
Simon Giesecke	9e2cf35b66	Reduced number of calls to container end method	2018-08-09 12:41:08 +02:00
Luca Boccassi	05e400a3e0	Merge pull request #3203 from sigiesec/update-wepoll ... Problem: wepoll outdated	2018-08-08 13:45:21 +01:00
Luca Boccassi	d9ade47630	Merge pull request #3202 from sigiesec/code-improvements ... Simplified and optimized several code fragments	2018-08-08 13:44:48 +01:00
Simon Giesecke	19a70ab682	Optimized and simplified zmq::timers_t::execute and zmq::timers_t::timeout	2018-08-07 16:54:35 +02:00